Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sidebar hover behavior and collapse button visibility #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IkramCode
Copy link

Fix sidebar hover behavior and collapse button visibility

  • Ensure collapse button only appears when the sidebar is not hovered.
  • Address invisible hover button issue by refining hover detection logic.
  • Hide the ChevronLeft icon when the sidebar is collapsed.

Copy link

vercel bot commented Aug 20, 2024

@IkramCode is attempting to deploy a commit to the BM-Samay Team on Vercel.

A member of the Team first needs to authorize it.

@IkramCode
Copy link
Author

fix for #135

Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bm-frontend- ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 6:45pm

@IkramCode
Copy link
Author

@Bot-Rakshit Why is this deployment still not successful . I am quite new in open source . It is showing for last two weeks that it needed to be merged . Is there something i still need to do ?

@Sama-004
Copy link
Contributor

Sama-004 commented Aug 31, 2024

@Bot-Rakshit Why is this deployment still not successful . I am quite new in open source . It is showing for last two weeks that it needed to be merged . Is there something i still need to do ?

It's not your fault. Someone with vercel access can only deploy it. There are 3 checks as you can see and 2 of them have passed (which means that your pr won't create any problems when deploying) and you don't need to pass the third one, it is passed if you are authorized to deploy it on vercel

@IkramCode
Copy link
Author

@Bot-Rakshit Why is this deployment still not successful . I am quite new in open source . It is showing for last two weeks that it needed to be merged . Is there something i still need to do ?

It's not your fault. Someone with vercel access can only deploy it. There are 3 checks as you can see and 2 of them have passed (which means that your pr won't create any problems when deploying) and you don't need to pass the third one, it is passed if you are authorized to deploy it on vercel

Thanks for sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants