Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase Code Coverage by 5% #44

Open
villanuevawill opened this issue May 24, 2018 · 28 comments
Open

Increase Code Coverage by 5% #44

villanuevawill opened this issue May 24, 2018 · 28 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@villanuevawill
Copy link
Collaborator

Simple. Codecov - bring the % up by 5. :D
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.15 ETH (88.6 USD @ $590.66/ETH) attached to it.

@villanuevawill villanuevawill added enhancement New feature or request good first issue Good for newcomers labels May 24, 2018
@renovatorruler
Copy link

Uhm, increasing code coverage is not that difficult as there are many cheats available for it, I would recommend defining this task more clearly.

@jvmaia
Copy link

jvmaia commented May 25, 2018

Hi, I'm interested in this issue. Can you explain this task more clearly as the @prashantpawar says, this task includes remove unused functions?

@gitcoinbot
Copy link

gitcoinbot commented May 25, 2018 •
edited
Loading

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

  1. @pfilippi24

has committed to working on this project to be completed 1 week, 3 days from now.

@villanuevawill, please see the below comments / questions regarding approach for this ticket from the bounty hunter(s):

@pgrzesik
Copy link
Contributor

Hey there, are you guys interested in more people working on this tasks so we can get code coverage even higher ? :)

@villanuevawill
Copy link
Collaborator Author

villanuevawill commented May 25, 2018 •
edited
Loading

@prashantpawar @jvmaia @pgrzesik
If you coordinate and don't duplicate work, 100000% interested in multiple contributions to write more tests, and I'd pay out each person the amount (ie. total 15% gain).

Lets follow the same criteria gitcoin has:

Criteria:

  • You must increase the code coverage (as measured by codecov) of this repo by 5%.
  • You must put (show) some thought into success / failure criteria for each method tested.
  • Please coordinate with other bounty hunters who are working on this bounty so you don't overlap work.

@villanuevawill
Copy link
Collaborator Author

Removing unused functions or other cheats do not count. This should be related to meaningful work and tests.

@pfilippi24
Copy link
Contributor

pfilippi24 commented May 26, 2018 •
edited
Loading

Splitting and coordinating sounds good.
I already started at the top. So, if it is fine with you, I'll be writing tests in the folders 'analytics' and 'authentication'

@villanuevawill
Copy link
Collaborator Author

@pfilippi24 sounds great and thanks!

@pfilippi24
Copy link
Contributor

@villanuevawill I think I can get the 5% by thoroughly testing the timeline_generator
Is that fine with you?

@villanuevawill
Copy link
Collaborator Author

@pfilippi24 👍

@pfilippi24
Copy link
Contributor

@villanuevawill
Added PR #46
Can you have a look and see if this is going in the right direction?
Technically it is already a 5% increase, but you are the one to judge :)

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 0.15 ETH (90.18 USD @ $601.21/ETH) has been submitted by:

  1. @pfilippi24

@villanuevawill please take a look at the submitted work:

@pgrzesik
Copy link
Contributor

@pfilippi24 Sounds great, I'm planning to start working on it tomorrow and I'll right away post on which parts of the project I'm working so we won't have overlapping PRs

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 0.15 ETH (79.07 USD @ $527.12/ETH) attached to this issue has been approved & issued to @pfilippi24.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.15 ETH (79.07 USD @ $527.12/ETH) attached to it.

@gitcoinbot
Copy link

gitcoinbot commented May 28, 2018 •
edited
Loading

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 9 months ago.
Please review their action plans below:

1) pgrzesik has started work.

Write tests for std_bounties

Learn more on the Gitcoin Issue Details page.

@pgrzesik
Copy link
Contributor

As I mentioned on Gitcoin, I'll write tests for std_bounties, currently started work on bounty_client and client_helpers - is that OK with you, @villanuevawill ?

@villanuevawill
Copy link
Collaborator Author

@pgrzesik that is great!

@nemani
Copy link

nemani commented May 30, 2018

I am also interested in helping do this!
But I will wait till the other developers are done with their PRs before starting, as I dont want the work to clash. :)

@gitcoinbot
Copy link

@pgrzesik Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@pgrzesik
Copy link
Contributor

pgrzesik commented Jun 1, 2018

@gitcoinbot Yes, I'm in the middle of it and I should have a finished PR ready for review later today. Sorry for a bit of a delay on my part.

Regards,
Piotr

@gitcoinbot
Copy link

@pgrzesik. 👋 thanks for the atMention, but you need to install @gitcoinbot on this repo for me to be able to respond. More details in the documentation.

✌️
@gitcoinbot

@pgrzesik
Copy link
Contributor

pgrzesik commented Jun 1, 2018

@villanuevawill I added some tests that are available in following PR: #56, I would appreciate any reviews/feedback.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 0.15 ETH (93.77 USD @ $625.14/ETH) has been submitted by:

  1. @pgrzesik

@villanuevawill please take a look at the submitted work:

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 0.15 ETH (90.71 USD @ $604.75/ETH) attached to this issue has been approved & issued to @pgrzesik.

@rishabhkumar296
Copy link

Hi, I am interested in working on this issue. Wish to know if someone else is working on it to avoid working on the overlapping parts.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 9 months ago.
Please review their action plans below:

1) pfilippi24 has started work.

Plan: Write more tests ;)

Learn more on the Gitcoin Issue Details page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@renovatorruler @pfilippi24 @rishabhkumar296 @villanuevawill @jvmaia @nemani @pgrzesik @gitcoinbot