Merge pull request #77 from Brainrotlang/feat/array_expression

fix(array): memory leaks in ExpressionList
Brainrotlang · Jan 16, 2025 · 18f2d8d · 18f2d8d
2 parents 2e31f28 + 2a5c870
commit 18f2d8d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/ast.c b/ast.c
@@ -2926,12 +2926,16 @@ size_t count_expression_list(ExpressionList* list)
 
 void free_expression_list(ExpressionList* list)
 {
-    while (list)
+    if (!list)
+        return;
+    ExpressionList* current = list->next;
+    while (current != list)
     {
-        ExpressionList* next = list->next;
-        free(list);
-        list = next;
+        ExpressionList* next = current->next;
+        free(current);
+        current = next;
     }
+    free(list);
 }
 
 void populate_array_varialbe(char* name, ExpressionList* list)

diff --git a/lang.y b/lang.y
@@ -228,12 +228,14 @@ declaration:
             set_array_variable($3, count_expression_list($7), get_current_modifiers(), $2);
             populate_array_varialbe($3, $7);
             $$ = create_array_declaration_node($3, count_expression_list($7), $2);
+            free_expression_list($7);
         }
     | optional_modifiers type IDENTIFIER LBRACKET INT_LITERAL RBRACKET EQUALS array_init
         {
             set_array_variable($3, $5, get_current_modifiers(), $2);
             populate_array_varialbe($3, $8);
             $$ = create_array_declaration_node($3, $5, $2);
+            free_expression_list($8);
         }
     ;