Skip to content

Commit

Permalink
fix outline only for kb focus issue && remove comments
Browse files Browse the repository at this point in the history
  • Loading branch information
subject026 committed Jan 17, 2024
1 parent 8d0b07e commit df66544
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/E2E.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,5 +110,5 @@ jobs:
if: always()
with:
name: playwright-report
path: playwright-report/
path: apps/site/playwright-report/
retention-days: 30
2 changes: 1 addition & 1 deletion apps/site/src/styles/base.css
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
@apply font-redhat;
}
* {
@apply focus:outline focus:outline-4 focus:outline-green-400 focus:outline-offset-4 rounded ;
@apply focus-visible:outline focus-visible:outline-4 focus-visible:outline-green-400 focus-visible:outline-offset-4 rounded ;
}
.transition-display {
transition: display 1000ms;
Expand Down
6 changes: 3 additions & 3 deletions apps/site/tests/desktop.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ test.describe("desktop - homepage", () => {
test("should not have any automatically detectable accessibility issues", async ({
page,
}) => {
await page.goto("/"); // 3
await page.goto("/");

const accessibilityScanResults = await new AxeBuilder({ page }).analyze(); // 4
const accessibilityScanResults = await new AxeBuilder({ page }).analyze();

expect(accessibilityScanResults.violations).toEqual([]); // 5
expect(accessibilityScanResults.violations).toEqual([]);
});
});
6 changes: 3 additions & 3 deletions apps/site/tests/mobile.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ test.describe("mobile - homepage", () => {
test("should not have any automatically detectable accessibility issues", async ({
page,
}) => {
await page.goto("/"); // 3
await page.goto("/");

const accessibilityScanResults = await new AxeBuilder({ page }).analyze(); // 4
const accessibilityScanResults = await new AxeBuilder({ page }).analyze();

expect(accessibilityScanResults.violations).toEqual([]); // 5
expect(accessibilityScanResults.violations).toEqual([]);
});
});
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"app": "pnpm --filter @breadchain.xyz/app",
"site-ui": "pnpm --filter @breadchain.xyz/site-ui",
"site:build": "pnpm install && pnpm site run build",
"test": "echo \"Error: no test specified\" && exit 1"
"site:test": "pnpm site playwright test"
},
"keywords": [],
"author": "",
Expand All @@ -18,4 +18,4 @@
"prettier": "^2.8.4",
"prettier-plugin-tailwindcss": "^0.2.8"
}
}
}

0 comments on commit df66544

Please sign in to comment.