From df66544a6e11710d23f3c26c1a12b74f9ce3b425 Mon Sep 17 00:00:00 2001 From: subject026 Date: Wed, 17 Jan 2024 14:53:04 +0000 Subject: [PATCH] fix outline only for kb focus issue && remove comments --- .github/workflows/E2E.yml | 2 +- apps/site/src/styles/base.css | 2 +- apps/site/tests/desktop.spec.ts | 6 +++--- apps/site/tests/mobile.spec.ts | 6 +++--- package.json | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/E2E.yml b/.github/workflows/E2E.yml index 528ed43..5289beb 100644 --- a/.github/workflows/E2E.yml +++ b/.github/workflows/E2E.yml @@ -110,5 +110,5 @@ jobs: if: always() with: name: playwright-report - path: playwright-report/ + path: apps/site/playwright-report/ retention-days: 30 diff --git a/apps/site/src/styles/base.css b/apps/site/src/styles/base.css index a47edbc..d46f60c 100644 --- a/apps/site/src/styles/base.css +++ b/apps/site/src/styles/base.css @@ -15,7 +15,7 @@ @apply font-redhat; } * { - @apply focus:outline focus:outline-4 focus:outline-green-400 focus:outline-offset-4 rounded ; + @apply focus-visible:outline focus-visible:outline-4 focus-visible:outline-green-400 focus-visible:outline-offset-4 rounded ; } .transition-display { transition: display 1000ms; diff --git a/apps/site/tests/desktop.spec.ts b/apps/site/tests/desktop.spec.ts index 79164b6..bc1ef45 100644 --- a/apps/site/tests/desktop.spec.ts +++ b/apps/site/tests/desktop.spec.ts @@ -9,10 +9,10 @@ test.describe("desktop - homepage", () => { test("should not have any automatically detectable accessibility issues", async ({ page, }) => { - await page.goto("/"); // 3 + await page.goto("/"); - const accessibilityScanResults = await new AxeBuilder({ page }).analyze(); // 4 + const accessibilityScanResults = await new AxeBuilder({ page }).analyze(); - expect(accessibilityScanResults.violations).toEqual([]); // 5 + expect(accessibilityScanResults.violations).toEqual([]); }); }); diff --git a/apps/site/tests/mobile.spec.ts b/apps/site/tests/mobile.spec.ts index d67d8e8..0c6e630 100644 --- a/apps/site/tests/mobile.spec.ts +++ b/apps/site/tests/mobile.spec.ts @@ -9,10 +9,10 @@ test.describe("mobile - homepage", () => { test("should not have any automatically detectable accessibility issues", async ({ page, }) => { - await page.goto("/"); // 3 + await page.goto("/"); - const accessibilityScanResults = await new AxeBuilder({ page }).analyze(); // 4 + const accessibilityScanResults = await new AxeBuilder({ page }).analyze(); - expect(accessibilityScanResults.violations).toEqual([]); // 5 + expect(accessibilityScanResults.violations).toEqual([]); }); }); diff --git a/package.json b/package.json index 425006b..49ceac1 100644 --- a/package.json +++ b/package.json @@ -9,7 +9,7 @@ "app": "pnpm --filter @breadchain.xyz/app", "site-ui": "pnpm --filter @breadchain.xyz/site-ui", "site:build": "pnpm install && pnpm site run build", - "test": "echo \"Error: no test specified\" && exit 1" + "site:test": "pnpm site playwright test" }, "keywords": [], "author": "", @@ -18,4 +18,4 @@ "prettier": "^2.8.4", "prettier-plugin-tailwindcss": "^0.2.8" } -} \ No newline at end of file +}