[MI-2088]: Review fixes of #872 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Improved the name of certain variable 2. Improved spacing
1.Changes the names of few variables 2.Improved code complexity
1.Changed the name of few variables
1.Changed the way to store assignee, mention, reporter and watching in struct so that the code can be easily tested
1. Changed the name of various variables 2. Used constants everywhere
1. Added Test cases 2. Used booleans instead of pointer in RolesForDMNotification
1. Modified test cases
1. Self reviewed
1. Changed the formatting 2. Changed the name of few variables 3. Improved code quality
1. Improved code quality
1. Improved code quality
1. Improved code quality
Kshitij-Katiyar
approved these changes
Oct 17, 2022
1. Solved a bug of getting null pointer on frontend. 2. Improved code quality
Nityanand13
changed the title
1. Improved code quality
1. Improved code quality
Kshitij-Katiyar
approved these changes
Oct 20, 2022
manojmalik20
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review fixes of #872