Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Try to fix generation of custom-elements.json file #4222

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

svanherk
Copy link
Contributor

It looks like this broke with the release of web-component-analyzer version 2.0.0 last week. Which makes sense as to why it was hard to track down a commit that broke it - we install this as part of the release workflow, so not tied to any code change on our part.

I don't know why removing the escape fixes it, but it works locally after I do this.

@svanherk svanherk requested a review from a team as a code owner October 30, 2023 17:58
@github-actions
Copy link
Contributor

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-4222/

Note
The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

Copy link
Member

@dlockhart dlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird indeed!

@svanherk svanherk merged commit f130e36 into main Oct 30, 2023
5 checks passed
@svanherk svanherk deleted the Fix_custom_elements_file branch October 30, 2023 18:19
@ghost
Copy link

ghost commented Oct 30, 2023

🎉 This PR is included in version 2.159.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants