-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: simplify list grid mode keyboard tooltip #4265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops.
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda surprised we don't have a vdiff test for this tooltip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The localizeHTML
really helps here!
🎉 This PR is included in version 2.161.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
As discussed, we're simplifying
<d2l-list>
's grid-mode keyboard instructions.