[DE55422] Input text has click event which propagates upwards. Stop p…

[jesseag]

…ropagation of this click event so the click handler in rubric feedback no longer receives this event.

Rally ticket: DE55422

Please refer to the following PR/discussion.
https://github.com/BrightspaceUI/htmleditor/pull/1914
https://github.com/BrightspaceUI/htmleditor/pull/1914#discussion_r1403460071

A click event is bubbling upwards from the d2l-input-text. After discussion with @grant-cleary in the PR linked above I am trying to determine whether we should stop propagation of this click event in d2l-input-text or if this is intended behaviour to have the click event propagate upwards? If this is intended behaviour then I will go ahead and merge my changes in the above htmleditor PR. However, if this is not the intended behaviour then I would like to stop propagation of this click event directly at the source. Thanks!

[github-actions]

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL	https://live.d2l.dev/prs/BrightspaceUI/core/pr-4278/

Note

The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

[jesseag]

@BrightspaceUI/gaudi-dev
Should I be concerned about the test/vdiff failures? A re-run fixed the failures but I'm not sure if I should be investigating them more closely.

[dlockhart]

As you discussed in that thread, I don't think we can stop propagating this event -- there's no telling if existing consumers could be relying on it, making this a breaking change. Native click events in general always propagate up through the DOM no matter what element was clicked (so this isn't a d2l-input-text specific problem)... I think it would be best to just handle this from the editor code.

[jesseag]

As you discussed in that thread, I don't think we can stop propagating this event -- there's no telling if existing consumers could be relying on it, making this a breaking change. Native click events in general always propagate up through the DOM no matter what element was clicked (so this isn't a d2l-input-text specific problem)... I think it would be best to just handle this from the editor code.

Sure this resonates with me. I don't want to be making any breaking changes.
I'll close this PR down then and merge in my fix in the htmleditor repo instead. Thanks!