Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating package-lock.json #5316

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Updating package-lock.json #5316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5af2b75
Auto Update Dependencies
github-actions[bot] Jan 17, 2025
f3ed05a
fix stylelint issues
margaree Jan 17, 2025
7be0ebe
Merge branch 'main' into ghworkflow/package_lock_auto_update
margaree Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/filter/filter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ class Filter extends FocusMixin(LocalizeCoreElement(RtlMixin(LitElement))) {
display: -webkit-box;
hyphens: auto;
-webkit-line-clamp: 2;
word-break: break-word;
overflow-wrap: anywhere;
}

d2l-list-item[selection-disabled] .d2l-filter-dimension-set-value,
Expand Down
2 changes: 1 addition & 1 deletion components/focus-trap/focus-trap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class FocusTrap extends FocusMixin(LitElement) {
display: inline-block;
}
:host([hidden]) {
display: hidden;
display: none;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hidden is not a supported value for display. I'll confirm that no where was using d2l-focus-trap hidden as this would suddenly cause previously visible cases to now not be.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not found any cases where hidden is used on d2l-focus-trap so this change should be safe.

}
`;
}
Expand Down
19 changes: 0 additions & 19 deletions components/form/demo/form-panel-demo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,28 +32,9 @@ class FormPanelDemo extends LitElement {
display: none;
}

.d2l-form-panel-demo-panel {
background-color: white;
border-radius: 8px;
padding: 20px;
}

.d2l-form-panel-demo-container {
margin-bottom: 10px;
}

.d2l-form-panel-demo-header {
align-items: top;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top is not a supported value for align-items. This css was also just no longer used so I cleaned it up.

cursor: pointer;
display: flex;
justify-content: space-between;
}

.d2l-form-panel-demo-text {
align-items: center;
display: flex;
margin: 0;
}
`];
}

Expand Down
1 change: 0 additions & 1 deletion components/form/form-errory-summary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ class FormErrorSummary extends LocalizeCoreElement(RtlMixin(LitElement)) {
}

.d2l-form-error-summary-header {
align-items: top;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top is not a supported value for align-items and this looked fine without so I didn't replace it with a different value.

cursor: pointer;
display: flex;
justify-content: space-between;
Expand Down
2 changes: 1 addition & 1 deletion components/inputs/input-textarea.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,10 @@ class InputTextArea extends InputInlineHelpMixin(FocusMixin(LabelledMixin(FormEl
.d2l-input-textarea-mirror {
line-height: 1rem;
overflow: hidden;
overflow-wrap: anywhere; /* prevent width from growing */
padding-bottom: 0.5rem;
padding-top: 0.5rem;
visibility: hidden;
word-break: break-word; /* prevent width from growing */
}
:host([no-padding]) .d2l-input {
padding-left: 0;
Expand Down
146 changes: 74 additions & 72 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading