-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DAYL-102 Update Expand-Collapse A11y Docn #5328
feat: DAYL-102 Update Expand-Collapse A11y Docn #5328
Conversation
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if it would be possible to improve the demo example. Currently if the user toggles expanded
using the table, aria-expanded
doesn't get updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks Chris!
dfe5dff
to
9a9944c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the small recommended changes LGTM!
…ng adjacent to the content
Co-authored-by: Margaree Peacocke <margaree.p@gmail.com>
bce0aaf
to
cf2ac43
Compare
🎉 This PR is included in version 3.81.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Jira Story
Similarly to many of the other PRs, this is another improvement to the a11y docn of the
d2l-expand-collapse-content
component. Due to the nature of the component, the only changes are in the readme and mostly instruct the users how to implement the component in an accessibility-friendly way.