Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DAYL-102 Update Expand-Collapse A11y Docn #5328

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

ChrisLabattD2L
Copy link
Contributor

Jira Story

Similarly to many of the other PRs, this is another improvement to the a11y docn of the d2l-expand-collapse-content component. Due to the nature of the component, the only changes are in the readme and mostly instruct the users how to implement the component in an accessibility-friendly way.

Copy link
Contributor

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-5328/

Note

The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

Copy link
Contributor

@margaree margaree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if it would be possible to improve the demo example. Currently if the user toggles expanded using the table, aria-expanded doesn't get updated.

components/expand-collapse/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@geurts geurts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Chris!

components/expand-collapse/README.md Outdated Show resolved Hide resolved
@ChrisLabattD2L ChrisLabattD2L force-pushed the clabatt/DAYL-102-Expand-Collapse-A11y-Docn branch from dfe5dff to 9a9944c Compare January 20, 2025 16:09
@ChrisLabattD2L ChrisLabattD2L marked this pull request as ready for review January 20, 2025 16:17
@ChrisLabattD2L ChrisLabattD2L requested a review from a team as a code owner January 20, 2025 16:17
Copy link
Contributor

@margaree margaree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the small recommended changes LGTM!

components/expand-collapse/README.md Outdated Show resolved Hide resolved
components/expand-collapse/README.md Outdated Show resolved Hide resolved
@ChrisLabattD2L ChrisLabattD2L force-pushed the clabatt/DAYL-102-Expand-Collapse-A11y-Docn branch from bce0aaf to cf2ac43 Compare January 21, 2025 15:18
@ChrisLabattD2L ChrisLabattD2L merged commit b067221 into main Jan 21, 2025
6 checks passed
@ChrisLabattD2L ChrisLabattD2L deleted the clabatt/DAYL-102-Expand-Collapse-A11y-Docn branch January 21, 2025 15:26
Copy link

🎉 This PR is included in version 3.81.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants