Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and Fix a few of the issues #7

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Update and Fix a few of the issues #7

wants to merge 24 commits into from

Conversation

caemor
Copy link

@caemor caemor commented Nov 12, 2019 •
edited
Loading

This PR seems to be similar to Palindromes PR with fixing a few of the issues, but based on simeonschaubs updates and therefore it is slightly different.

Fixes #3, #4

What this adds/changes:

  • add Settings/Parametersfield for units and language
  • add simple and basic tests for the free function (I don't have a paid account so I couldn't test the other functions)
  • switch to http_req with rust_tls because it has less deps and is faster to compile and is more than enough for this small usecase
  • add log so one can use things like debug!,...
  • split up files
  • update dependencies
  • fix/update a few of the weather types

What is still missing:

  • more and improved testcases for Locationspecifier, Settings,...

simeonschaub and others added 24 commits February 6, 2019 22:05
@simeonschaub
updated reqwest to 0.9
6e16453
@simeonschaub
updated url to 1.7
4cc390f
@simeonschaub
Made weather_types public
364489d
@simeonschaub
made temp_kf optional because crashes somtimes otherwise
eb769a8
@simeonschaub
Made some more variables in Weather be None by default
841f95d
@caemor
Update deps
056307e
@caemor
Work on adding more parameters like unit and lang
9767bcc
@caemor
fmt
be272b5
@caemor
- Make message from Sys optional (isn't always sent)
49fd227 
- Split up files
- Add Parameters (unfinished) for lang and units (metric,...)
- Switch to edition 2018
- add Settings/Parameters to each function
@caemor
update example
90e3f64
@caemor
Add .env file support for cargo test with api key
0b14412
@caemor
Add Settings/Parameters for units and language
bcedd84
@caemor
Fix a few weather types
9cf1772 
- add cnt to weather report5day
- fix timeslicehourly with optional rain and snow
- add snow
- fix cityshort with newly needed/included parameters (population, timezone, sunrise, sunset)
@caemor
-version change & cargo fmt
4a39eae
@caemor
Make Unit & Language public
183c1c2
@caemor
Only borrow LocationSpecifier
4e8e062
@caemor
- add default and partialeq to all weather_types
3b69cfa 
- make Wind:deg optional
- add WeatherReportCurrent::timezone
@nguiard
Add 'rain' and 'snow' to struct WeatherReportCurrent
93ba4ac 
Rain and Snow structs were already defined but were not yet included in
the WeatherReportCurrent struct, although they do occur in the JSON
response from OpenWeatherMaps.
@caemor
Merge pull request #1 from nguiard/master
3d96590 
Add 'rain' and 'snow' to struct WeatherReportCurrent
@caemor
Update api for failures
037ccde
@caemor
Update Lifetimes of LocationSpecifier
06a6665
@caemor
Add thiserror and remove all unwraps
66dbd57
@caemor
Improved Errortype
9f1d849
@caemor
Improved Error message
4fea978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serde errors are being masked, hindering debugging
3 participants
@caemor @simeonschaub @nguiard