Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add Enums to MATLAB #175

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ENH: Add Enums to MATLAB #175

wants to merge 3 commits into from

Conversation

NicerNewerCar
Copy link
Contributor

  • This is a follow-up to my comments on Pyautoscoper initial guess #119
  • This PR adds the three enumeration classes (CostFunction, OptimizationMethod, and OptimizationInitializationHeuristic) to improve usability and prevent invalid data from being passed to the Autoscoper server.

amymmorton
amymmorton approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@amymmorton amymmorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to switch to Name-Value Pairs in future - as the number of input arguments has ballooned. But Enum classes working. 👍

@NicerNewerCar
Copy link
Contributor Author

We may want to switch to Name-Value Pairs in future - as the number of input arguments has ballooned. But Enum classes working. 👍

I definitely agree, I opened an issue for this. #177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amymmorton amymmorton amymmorton approved these changes

@jcfr jcfr Awaiting requested review from jcfr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicerNewerCar @amymmorton