Pivot alignment and centering #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicerNewerCar
requested review from
jcfr,
amymmorton,
DajungYoon and
noahbrandess
NicerNewerCar
changed the title
|
lgtm |
jcfr
reviewed
Sep 4, 2024
| Mat4d manip = getManipulator(-1)->transform(); | ||
| CoordFrame vol_world = (CoordFrame::from_matrix(trans(manip)) * *tracker->trial()->getVolumeMatrix(-1)); | ||
|
|
||
| // The translation center is the relative position of the center of the volume to the corner coordinate. |
There was a problem hiding this comment.
Could you confirm that "translation center" is synonym with "translation origin" ?
There was a problem hiding this comment.
Yes this is correct, I believe this was called the "translation center" since, by default, it is set to the center of the volume.
| @@ -1033,4 +1033,12 @@ void Tracker::getFullDRR(unsigned int volumeID) const | |||
| } | |||
| } | |||
|
|
|||
| gpu::VolumeDescription* Tracker::getVolumeDescription(const int& index) | |||
| { | |||
| if (index == -1) { | |||
There was a problem hiding this comment.
Ensure consistency across the VolumeDescription API by removing the only method returning "Vec3f", which was added in the commit "ENH: Add short to align pivot with global axes".
jcfr
force-pushed
the
pivot-snap-back-to-center
branch
from
3d9e8ea
to
e6c260a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oto align the manipulator axes to the global axesPto snap the pivot back to the center of the volume