Some slight speedups of convert units #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running the "help_functions_chemdose_ph" vignette I started profiling some of the code as I noticed it was taking a while to run on my computer. Specifically I was profiling this snippet with profvis
The baseline case on main was taking ~7.5 seconds to run on my machine:
With convert_units accounting for ~2.1 seconds of runtime. Although results are very messy.
After these optimizations the example is down to ~7.0 seconds, and convert_units is down to 1.9 seconds. Not huge gains, but a start.
Going to continue to optimize from here, but wanted to at least show these gains were possible.