Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add personal builder page #22

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

krvvs
Copy link

@krvvs krvvs commented Oct 23, 2024

Description

1. Added a builder page

Created a personal profile page under packages/nextjs/app/builders.

The page displays:

  • Profile image of ENS(Ethereum Name Service) or Github account
  • ENS with a copy-to-clipboard feature for the address
  • Social media links
  • A brief bio for personal introduction

2. Added remote image handling for GitHub avatars

Updated the nextjs.config.js file to allow the Next.js Image Optimization API to load images from GitHub avatars (https://avatars.githubusercontent.com).

This change ensures that images from GitHub user profiles can be fetched and properly displayed in the application by specifying a remote pattern with the necessary protocol, hostname, and pathname.

builder-profile builder-profile-dark

Additional Information

Related Issues

Your ENS/address

0xe9Ad7D1C2069E0Fa9b5852Adc77C9196651BB8b8

Copy link

vercel bot commented Oct 23, 2024

@krvvs is attempting to deploy a commit to the BuidlGuidl Team on Vercel.

A member of the Team first needs to authorize it.

@krvvs krvvs marked this pull request as ready for review October 23, 2024 20:04
@phipsae phipsae self-requested a review October 23, 2024 21:38
Copy link
Collaborator

@phipsae phipsae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice page, and I appreciate that you're using some SE2 hooks like ENS. Thank you, @krvvs!

And a very well PR description!

I've added a few minor comments below.

@krvvs krvvs changed the title Feat: Add personal builder page feat: Add personal builder page Oct 24, 2024
@krvvs krvvs changed the title feat: Add personal builder page Add personal builder page Oct 24, 2024
@krvvs
Copy link
Author

krvvs commented Oct 24, 2024

@phipsae Thanks for your prompt review. Resolved all comments you gave!

@krvvs krvvs requested a review from phipsae October 24, 2024 11:21
Copy link
Collaborator

@phipsae phipsae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you spotted the error, just make this small change, and then we'll merge.

Thank you for your effort and the great page!

@krvvs krvvs requested a review from phipsae October 24, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2. Create your personal page
2 participants