Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Cohorts and Workshop sections images #34

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

andrealbiac
Copy link
Contributor

Uploading new images for the Cohorts section and the new Workshops section of main BG site.

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buidlguidl-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 3:21pm

@austintgriffith austintgriffith merged commit 61bdbe6 into main Sep 14, 2024
3 checks passed
@austintgriffith austintgriffith deleted the andrealbiac-patch-2 branch September 14, 2024 19:49
@carletex
Copy link
Contributor

Good evening, I'm Officer Carlos from PR police. May I see your driver's license and vehicle registration, please?

haha ok, I need more context here: Are these images for the new sections, right? Do we have the design + the copy for them?

Regarding the PR: check the naming standards on the public/assets folder:

image

lowercase + hyphens for spaces.

In this PR we have hyphen & underscore, capitalized words, and a space at the end of the second one.

image

Alright, I'm just going to issue you a warning for this minor violation 👮

@andrealbiac
Copy link
Contributor Author

Hey! Very funny but please don't issue this poor designer 🥺

Sorry, never uploaded pictures to the repo before & thought it was a bit different to other types of PRs, my bad! Context:

  • One is for a new section (the Workshops one) which we don't have the copy for yet
  • The other one is just replacing the image for the existing Cohorts section (no more changes on that one for now).

Also sorry about the messy names lol, should I replace them in this pr somehow to fix it?

And for next time I should open a PR with the new section & content right? + while uploading the necessary files to the repo.

Thanks Carlos aka PR police

@carletex
Copy link
Contributor

Thanks for the context @andrealbiac !

One is for a new section (the Workshops one) which we don't have the copy for yet

Ok, great. We can code it whenever we have the section design + copy

The other one is just replacing the image for the existing Cohorts section (no more changes on that one for now).

This should be an easy one! Just replacing this image, right?

image

we just need to replace this image: https://github.com/BuidlGuidl/buidlguidl.com/blob/main/packages/nextjs/pages/index.tsx#L265

Do you want to try? If not, @Pabl0cks can help!

Also sorry about the messy names lol, should I replace them in this pr somehow to fix it?

No worries, we can change them when we use them on the site (currently they are only in a folder waiting to be used)

Thanks Carlos aka PR police

All good. Thank you for being a good citizen 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants