Skip to content

Commit

Permalink
Merge pull request #64 from BuoyantIO/kleimkuhler/update-modules
Browse files Browse the repository at this point in the history
Update the minor/patch version of Go modules (and fix the max-rps issue).

As I was looking into #62, I was looking at some documentation and noticed the
signatures did not match. I updated the Go module minor versions and this
seems to have fixed this issue.

I did not look too much more into the actual implementation after this, but I
think we should at least get this change in and see if it resolves the user's
cases in #62.

Before (on every run):
```
strest-grpc on  master [!] via 🐹 v1.14.2 took 2s 
❯ ./strest-grpc max-rps
panic: runtime error: index out of range [0] with length 0

goroutine 530 [running]:
github.com/buoyantio/strest-grpc/max-rps.Config.Run.func2(0x0, 0x0, 0x0, 0xc0009ce500, 0x3, 0x3, 0x10078ab, 0xc0009cd0e0, 0xc000046fa0)
        /Users/kevin/Projects/BuoyantIO/strest-grpc/max-rps/max-rps.go:81 +0x246
..
```

After:
```
strest-grpc on  kleimkuhler/update-modules via 🐹 v1.14.2 took 3s 
❯ ./strest-grpc max-rps
[1 5921 5 17369 10 30836 20 36301 30 39182]
sigma (the overhead of contention):  0.060190636770402116
kappa (the overhead of crosstalk):  0.0011009192413378307
lambda (unloaded performance):  4786.482977774541
maxConcurrency: 29.000000
maxRps: 38780.939574
```

Signed-off-by: Kevin Leimkuhler <kevin@kleimkuhler.com>
  • Loading branch information
kleimkuhler authored Apr 30, 2020
2 parents 1467a28 + 992a0eb commit 5bba09e
Show file tree
Hide file tree
Showing 4 changed files with 279 additions and 33 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: 2
jobs:
build:
docker:
- image: circleci/golang:1.11.5-stretch
- image: circleci/golang:1.14.2-stretch
steps:
- checkout
- restore_cache:
Expand Down
28 changes: 18 additions & 10 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,15 +1,23 @@
module github.com/buoyantio/strest-grpc

go 1.14

require (
github.com/codahale/hdrhistogram v0.0.0-20161010025455-3a0bb77429bd
github.com/golang/protobuf v1.2.0
github.com/kr/pretty v0.1.0 // indirect
github.com/prometheus/client_golang v0.9.2
github.com/sirupsen/logrus v1.3.0
github.com/spf13/cobra v0.0.3
github.com/spf13/pflag v1.0.3 // indirect
golang.org/x/net v0.0.0-20190225153610-fe579d43d832
gonum.org/v1/gonum v0.0.0-20190221132855-8ea67971a689
google.golang.org/grpc v1.18.0
gopkg.in/check.v1 v1.0.0-20180628173108-788fd7840127
github.com/golang/protobuf v1.4.0
github.com/konsorten/go-windows-terminal-sequences v1.0.3 // indirect
github.com/prometheus/client_golang v1.6.0
github.com/sirupsen/logrus v1.5.0
github.com/spf13/cobra v1.0.0
github.com/spf13/pflag v1.0.5 // indirect
golang.org/x/exp v0.0.0-20200331195152-e8c3332aa8e5 // indirect
golang.org/x/net v0.0.0-20200425230154-ff2c4b7c35a0
golang.org/x/sys v0.0.0-20200428200454-593003d681fa // indirect
golang.org/x/text v0.3.2 // indirect
golang.org/x/tools v0.0.0-20200429213335-127c98bd7927 // indirect
gonum.org/v1/gonum v0.7.0
gonum.org/v1/netlib v0.0.0-20200317120129-c5a04cffd98a // indirect
google.golang.org/genproto v0.0.0-20200429120912-1f37eeb960b2 // indirect
google.golang.org/grpc v1.29.1
gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15
)
Loading

0 comments on commit 5bba09e

Please sign in to comment.