-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Range checks cable parameters (#287)
# CABLE ## Description Fixes #225 Add 2 flags to range checks ``` check%ranges (0, 1, 2) - When to do the range checks NO_CHECK, ON_TIMESTEP, ON_WRITE check%exit (.true., .false.) - Whether to exit the program if range checks are done, and out of range - the other option is to provide a warning ``` - Checks are being done in the following stages 1. Parameters of `soil` and `veg` before running the spinloop 2. Parameters when creating the NetCDF output file (some of them clash with `soil` and `veg` but code can be refactored in the future to account for that) 3. Landuse variables I/O 4. Variables in creating restart file 5. Variables at every timestep - Redesign `cable_output` with introducing `generate_out_write_acc`, and `check_and_write` - Change the range checks to be done in `cable_write` during `cable_output`. - Make `output_inclusion_type` dependencies clear between group output and individual values Tested with experiments in `bench_example` for `main` vs current commit. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--287.org.readthedocs.build/en/287/ <!-- readthedocs-preview cable end -->
- Loading branch information
Showing
10 changed files
with
1,677 additions
and
2,454 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.