Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namelist incompatibility and some incompatibilities for GNU compiler in the new checks%range #344

Closed
ccarouge opened this issue Jul 15, 2024 · 1 comment · Fixed by #345

Comments

@ccarouge
Copy link
Member

ccarouge commented Jul 15, 2024

PR #287 has changed the type of the range%checks entry in the cable.nml namelist, but the corresponding change in the namelist with the source code was not implemented.

In addition, the code has introduced some IF statements on integer values that will not compile with GNU compiler. These should be replaced with appropriate LOGICAL expressions.

Additionally, some non-standard line split symbols where introduced (\ instead of &).

ccarouge pushed a commit that referenced this issue Jul 15, 2024
@ccarouge ccarouge linked a pull request Jul 15, 2024 that will close this issue
1 task
@ccarouge ccarouge changed the title Update to cable.nml for the new type of the range%checks entry Fix namelist incompatibility and some incompatibilities for GNU compiler in the new checks%range Jul 15, 2024
@har917
Copy link
Collaborator

har917 commented Jul 15, 2024

@ccarouge Apologies if over the top - could we also update the docs at line 130 of meteorological_forcing.md and line 159 in pft_params_nml.md just to avoid confusion in the long run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants