Review process for new contributions #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccarouge
force-pushed
the
186-contribution-guidelines-review
branch
from
63742c5 to
3ab8f45
Compare
ccarouge
force-pushed
the
186-contribution-guidelines-review
branch
from
b887058 to
5d7b808
Compare
ccarouge
added
the
priority:low
|
@bschroeter When writing this, I realised having a quick explanation of the PR interface in the CABLE documentation would be good. But I think it needs to come earlier in the contribution guidelines so I'm not including it with this work. The pages modified by this PR can be found here and here in the rendered documentation. |
bschroeter
requested changes
May 15, 2024
documentation/docs/developer_guide/contribution/review_guide.md
Outdated
Show resolved
Hide resolved
bschroeter
approved these changes
May 21, 2024
|
Looks good, might want to check that markdown link check thing. |
|
The markdown checker is failing on files that have been removed from main but still exist in the outdated documentation in the PR branch. These will be removed from the documentation once merged with main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CABLE
Thank you for submitting a pull request to the CABLE Project.
Description
Guidelines for the review of new contributions.
Fixes #186
Type of change
Please delete options that are not relevant.
Checklist
Please add a reviewer when ready for review.
📚 Documentation preview 📚: https://cable--289.org.readthedocs.build/en/289/