Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update content of pft_params.nml options under User Guide #299

Merged

Conversation

rkutteh
Copy link
Collaborator

@rkutteh rkutteh commented May 20, 2024

Description

Updated content of pft_params.nml options under User Guide as a side task of another GW-related task.
Added text and tables to provide more and neater content.

Type of change

  • New or updated documentation

📚 Documentation preview 📚: https://cable--299.org.readthedocs.build/en/299/

@rkutteh rkutteh added the documentation Improvements or additions to documentation label May 20, 2024
@rkutteh rkutteh requested a review from ccarouge May 20, 2024 11:46
@rkutteh rkutteh self-assigned this May 20, 2024
@rkutteh rkutteh linked an issue May 20, 2024 that may be closed by this pull request
Copy link
Member

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new table for the default values. Some minor changes proposed, in particular to improve the rendering of table 2.

documentation/docs/user_guide/inputs/pft_params_nml.md Outdated Show resolved Hide resolved
Co-authored-by: Claire Carouge <ccarouge@users.noreply.github.com>
@rkutteh rkutteh requested a review from ccarouge June 2, 2024 12:20
Copy link
Member

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. You are the one to merge it in main when you are certain it is ready.

@rkutteh rkutteh merged commit c2c0316 into main Jun 3, 2024
3 checks passed
@rkutteh rkutteh deleted the 291-update-content-of-pft_paramsnml-options-under-user-guide branch June 3, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update content of pft_params.nml options under User Guide
2 participants