Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defined ncid_mask for met data files with multiple sites. Fixes #306. #308

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

rml599gh
Copy link
Contributor

@rml599gh rml599gh commented Jun 5, 2024

CABLE

Thank you for submitting a pull request to the CABLE Project.

Description

The model crashed when trying to run multiple sites in the met data file. This was because ncid_mask was not defined.

Fixes #306

Type of change

Please delete options that are not relevant.

  • [X ] Bug fix

Checklist

  • The new content is accessible and located in the appropriate section.
  • I have checked that links are valid and point to the intended content.
  • I have checked my code/text and corrected any misspellings

Please add a reviewer when ready for review.


📚 Documentation preview 📚: https://cable--308.org.readthedocs.build/en/308/

@rml599gh rml599gh requested a review from ccarouge June 5, 2024 05:56
Copy link
Collaborator

@JhanSrbinovsky JhanSrbinovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you requested a particular reviewer Rachel? It on the top right of the PR page. I suggest Claire and she can advise of any further testing NRI requires.

Copy link
Member

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, we want some test results as part of the pull request. This isn't a case that is covered by benchcab yet (something to add). But considering this is a bug fix with a clear crash/no crash case that's a good enough test for now.

I have added one small change but I'm approving anyway. You can apply the suggestion and then you can merge the PR. The policy is for the author to merge as that gives you a last chance to spot an error.

@rml599gh I'd be curious to get your configuration to add it to benchcab. Then we could later check that we get the same results running the fluxnet sites individually or bundled in the met file.

src/offline/cable_input.F90 Outdated Show resolved Hide resolved
Comment alignment

Co-authored-by: Claire Carouge <ccarouge@users.noreply.github.com>
@rml599gh rml599gh merged commit 69331b6 into main Jun 6, 2024
3 checks passed
@rml599gh rml599gh deleted the 306-ncid_mask-may-not-be-correct branch June 6, 2024 05:56
@access-hive-bot
Copy link

This pull request has been mentioned on ACCESS Hive Community Forum. There might be relevant details there:

https://forum.access-hive.org.au/t/cable-site-runs-with-access-forcing/2108/7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ncid_mask may not be correct for some applications - possible bug cable_input.F90
4 participants