Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ice density to 917 kg/m3 #332

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

rkutteh
Copy link
Collaborator

@rkutteh rkutteh commented Jul 3, 2024

Set density_ice = 917 kg/m3 in cable_phys_constants_mod.F90 and soilin%rhosoil to 917 kg/m3 for 'Permanent ice' in cable_soilparm.nml, in connection to #326


📚 Documentation preview 📚: https://cable--332.org.readthedocs.build/en/332/

@rkutteh rkutteh added the quick label Jul 3, 2024
@rkutteh rkutteh requested a review from ccarouge July 3, 2024 01:49
@rkutteh rkutteh self-assigned this Jul 3, 2024
@rkutteh rkutteh linked an issue Jul 3, 2024 that may be closed by this pull request
Copy link
Member

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the current unavailability of analysis in modelevaluation.org, this PR is reviewed without the scientific evaluation results.

@rkutteh Good to go.

@rkutteh rkutteh merged commit b7b5850 into main Jul 26, 2024
7 checks passed
@rkutteh rkutteh deleted the 331-set-ice-density-to-917-kgm3 branch July 26, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set ice density to 917 kg/m3
2 participants