Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialise casaflux%frac_sapwood=1 for use in casa_rplant (#373) #374

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

rml599gh
Copy link
Contributor

@rml599gh rml599gh commented Aug 19, 2024

CABLE

Thank you for submitting a pull request to the CABLE Project.

Description

casaflux%frac_sapwood needs to be initialised to 1 for the correct calculation of casaflux%crmplant(:,wood) in casa_rplant when cable_user%CALL_climate is not true.
This had been done in casa_inout at #274 but this subroutine is only used for offline simulations.
This change does the initialisation, in casa_init_pk, for ESM1.5/ESM1.6 cases.

Fixes #373

Type of change

Please delete options that are not relevant.

  • [X ] Bug fix

Checklist

  • The new content is accessible and located in the appropriate section.
  • I have checked that links are valid and point to the intended content.
  • I have checked my code/text and corrected any misspellings

Please add a reviewer when ready for review.


📚 Documentation preview 📚: https://cable--374.org.readthedocs.build/en/374/

@rml599gh rml599gh linked an issue Aug 19, 2024 that may be closed by this pull request
@rml599gh rml599gh requested a review from ccarouge August 19, 2024 02:21
@rml599gh
Copy link
Contributor Author

Plots are January plant respiration (first month of a PIcontrol run). Note range on colour bar.

With frac_sapwood=1 initialisation (test done in copy of code from branch 368-merge-cablegithub-with-esm15-cable-for-esm16 in order to build with UM).
image

Without frac_sapwood iniatilisation in casa_init_pk (code copied from CABLE github branch 368-merge-cablegithub-with-esm15-cable-for-esm16
image

ACCESS-ESM1.5 executable
image

@rml599gh rml599gh requested a review from a team August 19, 2024 02:34
Copy link
Member

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Sorry for the delay.

@rml599gh rml599gh merged commit b1de4d8 into main Sep 15, 2024
7 checks passed
@rml599gh rml599gh deleted the 373-frac_sapwood-initialisation-for-esm16 branch September 15, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

frac_sapwood initialisation for ESM1.6
2 participants