-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust plumbing to USE cable_surface_types offline #446
Conversation
@har917 you're tagged in the issue but perhaps here is more appropriate |
Indent issue.
…ne-we-can-get-round-the-need-for-this-by-modifying-the-files-names-in-the-offlinecoupled-codebases-to-be-the-same
@bschroeter can you have a look at this. The next tranche of AM3 updates will be much simpler if this does in first |
Actually to get ESM1,6 to work as well - so Labels etc will be updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine for me. I've made a commit (so pull before pushing if needed) to align all the USE statements where it was obviously needed from the changes view.
Is there a plan to change cable_surface_types.F90
to a namelist down the track?
absolutely |
CABLE
The same module name can indeed be USEd as there are seperate versions picked up by coupled/offline apps. However some additional plumbing needs to be tweaked offline.
Please see issue for further details:
Fixes #436
Type of change
Checklist
Please add a reviewer when ready for review.
📚 Documentation preview 📚: https://cable--446.org.readthedocs.build/en/446/