Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust plumbing to USE cable_surface_types offline #446

Conversation

JhanSrbinovsky
Copy link
Collaborator

@JhanSrbinovsky JhanSrbinovsky commented Oct 30, 2024

CABLE

The same module name can indeed be USEd as there are seperate versions picked up by coupled/offline apps. However some additional plumbing needs to be tweaked offline.

Please see issue for further details:
Fixes #436

Type of change

Checklist

  • The new content is accessible and located in the appropriate section.
  • I have checked that links are valid and point to the intended content.
  • I have checked my code/text and corrected any misspellings

Please add a reviewer when ready for review.


📚 Documentation preview 📚: https://cable--446.org.readthedocs.build/en/446/

@JhanSrbinovsky
Copy link
Collaborator Author

@har917 you're tagged in the issue but perhaps here is more appropriate

Indent issue.
@JhanSrbinovsky JhanSrbinovsky self-assigned this Nov 6, 2024
@JhanSrbinovsky JhanSrbinovsky added the priority:high High priority issues that should be included in the next release. label Nov 6, 2024
@JhanSrbinovsky JhanSrbinovsky added this to the ESM1.6 FastTrack milestone Nov 6, 2024
…ne-we-can-get-round-the-need-for-this-by-modifying-the-files-names-in-the-offlinecoupled-codebases-to-be-the-same
@JhanSrbinovsky
Copy link
Collaborator Author

@bschroeter can you have a look at this. The next tranche of AM3 updates will be much simpler if this does in first

@JhanSrbinovsky
Copy link
Collaborator Author

@bschroeter can you have a look at this. The next tranche of AM3 updates will be much simpler if this does in first

Actually to get ESM1,6 to work as well - so Labels etc will be updated

Copy link
Member

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine for me. I've made a commit (so pull before pushing if needed) to align all the USE statements where it was obviously needed from the changes view.

Is there a plan to change cable_surface_types.F90 to a namelist down the track?

@JhanSrbinovsky JhanSrbinovsky merged commit af51c0a into main Nov 24, 2024
7 checks passed
@JhanSrbinovsky JhanSrbinovsky deleted the 436-ifdef-okay-for-now-but-surely-for-this-one-we-can-get-round-the-need-for-this-by-modifying-the-files-names-in-the-offlinecoupled-codebases-to-be-the-same branch November 24, 2024 23:02
@JhanSrbinovsky
Copy link
Collaborator Author

Is there a plan to change cable_surface_types.F90 to a namelist down the track?

absolutely

@JhanSrbinovsky JhanSrbinovsky restored the 436-ifdef-okay-for-now-but-surely-for-this-one-we-can-get-round-the-need-for-this-by-modifying-the-files-names-in-the-offlinecoupled-codebases-to-be-the-same branch November 25, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high High priority issues that should be included in the next release.
Projects
None yet
3 participants