ESM16 version of CABLE #468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cable_surface_types SHOULD exist by now
|
Closing in favour of #474. As per discussions with @JhanSrbinovsky, this is not intended to be merged. |
JhanSrbinovsky
added a commit
that referenced
this pull request
Nov 26, 2024
# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description With these minor changes CABLE:main can be cloned directly into the ESM1.6 / UM7.3 code under umbase_hg3. NB:A lot of the changes are replicated from PRs that are waiting to be reviewed. Fixes #473, #468 ## Type of change For ESM1.6. A library can be built directly from this code benchcab regression tessts successful: [benchmark_cable_qsub.sh.o128621374.txt](https://github.com/user-attachments/files/17748080/benchmark_cable_qsub.sh.o128621374.txt) <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--474.org.readthedocs.build/en/474/ <!-- readthedocs-preview cable end --> --------- Co-authored-by: Claire Carouge <claire.carouge@anu.edu.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CABLE
Thank you for submitting a pull request to the CABLE Project.
Description
ESM15-CABLE3 is updated to build from ESM16 repo. Note: This builds through script based build but currently fails in ESM16 deployment.
Version of CABLE3 here is from main@f1bc23ab2ab0ee9041bb20f5e11f9077844d569f.
Several directories/fieles are removed. They are either unnecessary or get in the way of build, or both.
Fixes #(issue)
Type of change
Please delete options that are not relevant.
Checklist
Please add a reviewer when ready for review.
📚 Documentation preview 📚: https://cable--468.org.readthedocs.build/en/468/