Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

488 merge canopy developments from am3 #489

Merged
merged 29 commits into from
Nov 27, 2024
Merged

488 merge canopy developments from am3 #489

Show file tree
Hide file tree
Changes from 27 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
9d15e92
coupled - this appliation directory SHOULD have nothing to do with th…
JhanSrbinovsky Aug 14, 2024
d342f84
manually merge changes from AM3
JhanSrbinovsky Aug 14, 2024
112870c
add ice_cable index to grid_constants
JhanSrbinovsky Aug 14, 2024
61138ab
move definition of nCNPpool_tile TYPE members dimensions to coupled/
JhanSrbinovsky Oct 4, 2024
9e97c01
offline define parameters which in JAC are read through
JhanSrbinovsky Oct 6, 2024
9e7403b
remove redundant code - no need to comment
JhanSrbinovsky Oct 8, 2024
ced4f8b
remove redundant code - no need to comment
JhanSrbinovsky Oct 8, 2024
d17eda7
modifications from AM3 development - will change output
JhanSrbinovsky Oct 8, 2024
1332ed0
modifications from AM3 development
JhanSrbinovsky Oct 8, 2024
ec27ffe
likely change in regression testing due to correction factors sqitched
JhanSrbinovsky Oct 8, 2024
cd6cf7d
modifications from AM3 development
JhanSrbinovsky Oct 8, 2024
55adef5
only used in GW
JhanSrbinovsky Oct 8, 2024
55263c1
revert these to main: versions
JhanSrbinovsky Oct 10, 2024
0bd6c0f
AM3 version
JhanSrbinovsky Oct 10, 2024
6d8cf3e
revert to main: version
JhanSrbinovsky Oct 10, 2024
dda93c2
revert to main: version
JhanSrbinovsky Oct 10, 2024
a7292e2
not building yet
JhanSrbinovsky Oct 16, 2024
9a4f6e9
build bugs fixed
JhanSrbinovsky Oct 16, 2024
a5120e3
Update cbl_latent_heat.F90
JhanSrbinovsky Oct 28, 2024
74832fc
Update CMakeLists.txt
JhanSrbinovsky Oct 31, 2024
992dd99
Update CMakeLists.txt
JhanSrbinovsky Oct 31, 2024
298dd06
USE global index/parameter
JhanSrbinovsky Oct 31, 2024
a7863fe
format
JhanSrbinovsky Oct 31, 2024
7b86584
merge
JhanSrbinovsky Nov 6, 2024
b3c27ad
Merge branch '421-from-am3-canopy_rebased' into 488-merge-canopy-deve…
JhanSrbinovsky Nov 26, 2024
e435d97
AM3 implementation of init_wetfac crept in. Although f90 should be
JhanSrbinovsky Nov 26, 2024
bcb8346
rm explicit typecasting used in AM3
JhanSrbinovsky Nov 26, 2024
d1c0e4b
rm redundant USE elements
JhanSrbinovsky Nov 26, 2024
52f2e3a
uppercase f90
JhanSrbinovsky Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

AM3 implementation of init_wetfac crept in. Although f90 should be
capitalized as automatically triggers -fpp compilation flag AND every
other files is F90 AND every JULES file is F90

Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ add_library(
src/science/canopy/cbl_dryLeaf.F90
src/science/canopy/cbl_friction_vel.F90
src/science/canopy/cbl_fwsoil.F90
src/science/canopy/cbl_init_wetfac_mod.f90
src/science/canopy/cbl_init_wetfac_mod.F90
src/science/canopy/cbl_latent_heat.F90
src/science/canopy/cbl_photosynthesis.F90
src/science/canopy/cbl_pot_evap_snow.F90
Expand Down
117 changes: 70 additions & 47 deletions src/science/canopy/cable_canopy.F90
View file
Open in desktop
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AM3 version treatment of conversion (assuming 1e3 corresponds to units)

  ! Calculate dewfall: from negative lh wet canopy + neg. lh dry canopy:
  canopy%dewmm = - (MIN(0.0,canopy%fevw) + MIN(0.0_r_2,canopy%fevc)) * &
       dels / air%rlam

and cansto

Original file line number Diff line number Diff line change
Expand Up @@ -6,24 +6,22 @@ MODULE cable_canopy_module
PRIVATE

CONTAINS

SUBROUTINE define_canopy(bal,rad,rough,air,met,dels,ssnow,soil,veg, canopy,climate, sunlit_veg_mask, reducedLAIdue2snow )
USE cable_def_types_mod
USE cbl_radiation_module, ONLY : radiation
USE cable_air_module
USE cable_common_module
USE cable_roughness_module

USE cbl_friction_vel_module, ONLY : comp_friction_vel, psim, psis
USE cbl_pot_evap_snow_module, ONLY : Penman_Monteith, Humidity_deficit_method
USE cbl_qsat_module, ONLY : qsatfjh, qsatfjh2
USE cbl_zetar_module, ONLY : update_zetar
USE cable_latent_heat_module, ONLY : latent_heat_flux
USE cable_wetleaf_module, ONLY : wetleaf
USE cbl_dryLeaf_module, ONLY : dryLeaf
! subrs
USE cbl_radiation_module, ONLY : radiation
USE cbl_friction_vel_module, ONLY : comp_friction_vel, psim, psis
USE cbl_pot_evap_snow_module, ONLY : Penman_Monteith, Humidity_deficit_method
USE cbl_qsat_module, ONLY : qsatfjh, qsatfjh2
USE cbl_zetar_module, ONLY : update_zetar
USE cable_latent_heat_module, ONLY : latent_heat_flux
USE cable_wetleaf_module, ONLY : wetleaf
USE cbl_dryLeaf_module, ONLY : dryLeaf
USE cable_within_canopy_module, ONLY : within_canopy
USE cbl_SurfaceWetness_module, ONLY : Surf_wetness_fact

! data
USE cable_common_module, ONLY: cable_runtime, cable_user
! physical constants
USE cable_phys_constants_mod, ONLY : CTFRZ => TFRZ
USE cable_phys_constants_mod, ONLY : CRMAIR => RMAIR
Expand Down Expand Up @@ -65,6 +63,12 @@ SUBROUTINE define_canopy(bal,rad,rough,air,met,dels,ssnow,soil,veg, canopy,clima
USE cable_math_constants_mod, ONLY : CPI_C => PI
USE cable_other_constants_mod, ONLY : CLAI_THRESH => LAI_THRESH

USE grid_constants_mod_cbl, ONLY: ICE_SoilType

USE cable_def_types_mod
USE cable_air_module
USE cable_roughness_module

IMPLICIT NONE

TYPE (balances_type), INTENT(INOUT) :: bal
Expand All @@ -80,7 +84,7 @@ SUBROUTINE define_canopy(bal,rad,rough,air,met,dels,ssnow,soil,veg, canopy,clima
TYPE (veg_parameter_type), INTENT(INOUT) :: veg

REAL :: reducedLAIdue2snow(mp)
logical :: sunlit_veg_mask(mp)
LOGICAL :: sunlit_veg_mask(mp)
REAL, INTENT(IN) :: dels ! integration time setp (s)
INTEGER :: &
iter, & ! iteration #
Expand Down Expand Up @@ -151,16 +155,21 @@ SUBROUTINE define_canopy(bal,rad,rough,air,met,dels,ssnow,soil,veg, canopy,clima

INTEGER :: j

INTEGER, SAVE :: call_number =0

! END header

call_number = call_number + 1

!H! vNot sure that this is appropriate for JULES standalone - HaC
!H!IF( .NOT. cable_runtime%um) &
canopy%cansto = canopy%oldcansto

! local vars in calc of Surface conductance
REAL :: LAI_min(mp)
REAL :: Rel_bigLeafLAI_sun(mp)
REAL :: Rel_bigLeafLAI_shd(mp)
REAL :: minCanopyCond(mp)
REAL :: canopy_conductance(mp)
REAL :: Rel_moisture(mp)
REAL :: soil_conductance(mp)
REAL :: Surf_conductance(mp)
! END header

! Not sure that this is appropriate for JULES standalone - HaC either
IF( .NOT. cable_runtime%um ) THEN
canopy%cansto = canopy%oldcansto
ENDIF
ALLOCATE( cansat(mp), gbhu(mp,mf))
ALLOCATE( dsx(mp), fwsoil(mp), tlfx(mp), tlfy(mp) )
ALLOCATE( ecy(mp), hcy(mp), rny(mp))
Expand Down Expand Up @@ -394,23 +403,17 @@ SUBROUTINE define_canopy(bal,rad,rough,air,met,dels,ssnow,soil,veg, canopy,clima
hcy = 0.0 ! init current estimate lat heat
ecy = rny - hcy ! init current estimate lat heat

CALL dryLeaf( dels, rad, rough, air, met, &
veg, canopy, soil, ssnow, dsx, &
fwsoil, tlfx, tlfy, ecy, hcy, &
rny, gbhu, gbhf, csx, cansat, &
ghwet, iter,climate, sum_rad_gradis, sum_rad_rniso )
CALL dryLeaf( dels, rad, rough, air, met, veg, canopy, soil, ssnow, &
dsx, fwsoil, tlfx, tlfy, ecy, hcy, rny, gbhu, gbhf, csx, &
cansat, ghwet, iter, climate, sum_rad_gradis, &
sum_rad_rniso )


CALL wetLeaf( dels, &
cansat, tlfy, &
gbhu, gbhf, ghwet, &
mp, CLAI_thresh, CCAPP, CRmair, &
reducedLAIdue2snow, sum_rad_rniso, sum_rad_gradis, &
canopy%fevw, canopy%fevw_pot, canopy%fhvw, &
canopy%fwet, canopy%cansto, air%rlam, air%dsatdk, &
CALL wetLeaf( dels, cansat, tlfy, gbhu, gbhf, ghwet, mp, CLAI_thresh, &
CCAPP, CRmair, reducedLAIdue2snow, sum_rad_rniso, &
sum_rad_gradis, canopy%fevw, canopy%fevw_pot, canopy%fhvw, &
canopy%fwet, canopy%cansto, air%rlam, air%dsatdk, &
met%tvair, met%tk, met%dva, air%psyc )


! Calculate latent heat from vegetation:
! Calculate sensible heat from vegetation:
! Calculate net rad absorbed by canopy:
Expand Down Expand Up @@ -688,16 +691,36 @@ SUBROUTINE define_canopy(bal,rad,rough,air,met,dels,ssnow,soil,veg, canopy,clima

canopy%cduv = canopy%us * canopy%us / (MAX(met%ua,CUMIN))**2

!---diagnostic purposes
canopy%gswx_T = rad%fvlai(:,1)/MAX( CLAI_THRESH, canopy%vlaiw(:) ) &
* canopy%gswx(:,1) + rad%fvlai(:,2) / MAX(CLAI_THRESH, &
canopy%vlaiw(:))*canopy%gswx(:,2)
! Evaluate Total Surface conductance !---diagnostic purposes

!vlaiw is already limted?
LAI_min(:) = MAX( CLAI_THRESH, canopy%vlaiw(:) )
Rel_bigLeafLAI_sun(:) = rad%fvlai(:,1) / LAI_min(:)
Rel_bigLeafLAI_shd(:) = rad%fvlai(:,2) / LAI_min(:)

! The surface conductance below is required by dust scheme; it is composed from canopy and soil conductances
canopy%gswx_T = (1.-rad%transd)*MAX(1.e-06,canopy%gswx_T ) + & !contribution from canopy conductance
rad%transd*(.01*ssnow%wb(:,1)/soil%sfc)**2 ! + soil conductance; this part is done as in Moses
WHERE ( soil%isoilm == 9 ) canopy%gswx_T = 1.e6 ! this is a value taken from Moses for ice points
!total stomatal conductance
canopy_conductance(:) = Rel_bigLeafLAI_sun(:) * canopy%gswx(:,1) &
+ Rel_bigLeafLAI_shd(:) * canopy%gswx(:,2)

! Surface conductance required by dust scheme
! Canopy conductance
minCanopyCond(:) = MAX( 1.e-06, canopy_conductance(:) )
canopy_conductance(:) = (1.-rad%transd(:))* minCanopyCond(:)

! Soil conductance - following MOSES method
Rel_moisture(:) = ssnow%wb(:,1) / soil%sfc(:)
soil_conductance(:) = rad%transd(:) * ( 0.01*Rel_moisture )**2

! Combined Surface conductance
Surf_conductance(:) = canopy_conductance(:) + soil_conductance(:)

! this is a value taken from MOSES for ice points
WHERE ( soil%isoilm == ICE_SoilType )
Surf_conductance = 1.e6
END WHERE

canopy%gswx_T(:) = Surf_conductance(:) !fill CABLE type for now

canopy%cdtq = canopy%cduv * &
( LOG( rough%zref_uv / rough%z0m) - &
psim( canopy%zetar(:,NITER) * rough%zref_uv/rough%zref_tq, mp, CPI_C ) &
Expand Down
18 changes: 11 additions & 7 deletions src/science/canopy/cbl_SurfaceWetness.F90
View file
Open in desktop
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AM3 had neater interface. The explicit REAL typecasting is perhaps unnecessary as it is handled here that was used in AM3 - HOWEVER continued removal of r_2 is advantageous. As argued a million times, REAL(selected_real_kind) does not change CPU hardeware. it's either a 32,64,128 bit machine. All values of selected_real_kind fall into their nearest bin (being either 32,64,128 bit etc). Here r_2 defaults to double. In the UM everything is compiled as -i8, -r8 so r_2 is meaningless and only causes complications in development/refactoring especially when TYPES/kinds dont match up. Additionally the UKMO discouraged us from using r_2, special KINDs. However they have since adopted them themselves. Having many different KINDs on either side of the interface is problematic. Last I spoke with them they were uncertain of what this would all look like with LFRic. At any rate it is easier if we just lay off the r_2 for the moment and re-implement a consistent approach at a later date when we know better what is happening.

Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,17 @@ SUBROUTINE Surf_wetness_fact( cansat, canopy, ssnow,veg, met, soil, dels )
!call saturated_fraction(ssnow,soil,veg)
ssnow%satfrac(:) = 1.0e-8
ssnow%rh_srf(:) = 1.0

CALL initialize_wetfac(mp, ssnow%wetfac, soil%swilt, soil%sfc, ssnow%wb, ssnow%wbice, ssnow%snowd, veg%iveg, met%tk, Ctfrz)

! owetfac introduced to reduce sharp changes in dry regions,
! especially in offline runs in which there may be discrepancies b/n
! timing of precip and temperature change (EAK apr2009)
ssnow%wetfac = 0.5*(ssnow%wetfac + ssnow%owetfac)

!This is updating wetfac iusing same calc as initialization
!originally code in canopy used 1e-6 as MIN
CALL initialize_wetfac( mp, ssnow%wetfac, soil%swilt, soil%sfc, &
ssnow%wb(:,1), ssnow%wbice(:,1), ssnow%snowd, &
veg%iveg, met%tk, Ctfrz )

! owetfac introduced to reduce sharp changes in dry regions,
! especially in offline runs in which there may be discrepancies b/n
! timing of precip and temperature change (EAK apr2009)
ssnow%wetfac = 0.5*(ssnow%wetfac + ssnow%owetfac)



Expand Down
75 changes: 40 additions & 35 deletions src/science/canopy/cbl_dryLeaf.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ SUBROUTINE dryLeaf( dels, rad, rough, air, met, &
USE cbl_photosynthesis_module, ONLY : photosynthesis
USE cbl_fwsoil_module, ONLY : fwsoil_calc_std, fwsoil_calc_non_linear, &
fwsoil_calc_Lai_Ktaul, fwsoil_calc_sli
!data
USE cable_surface_types_mod, ONLY: evergreen_broadleaf, deciduous_broadleaf
USE cable_surface_types_mod, ONLY: evergreen_needleleaf, deciduous_needleleaf
USE cable_surface_types_mod, ONLY: c3_grassland, tundra, c3_cropland

! maths & other constants
USE cable_other_constants_mod, ONLY : CLAI_THRESH => LAI_THRESH
! physical constants
Expand All @@ -26,6 +31,7 @@ SUBROUTINE dryLeaf( dels, rad, rough, air, met, &
USE cable_phys_constants_mod, ONLY : CRGAS => RGAS
USE cable_phys_constants_mod, ONLY : CCAPP => CAPP
USE cable_phys_constants_mod, ONLY : CRMAIR => RMAIR
USE cable_phys_constants_mod, ONLY : density_liq
! photosynthetic constants
USE cable_photo_constants_mod, ONLY : CMAXITER => MAXITER ! only integer here
USE cable_photo_constants_mod, ONLY : CTREFK => TREFK
Expand All @@ -35,6 +41,8 @@ SUBROUTINE dryLeaf( dels, rad, rough, air, met, &
USE cable_photo_constants_mod, ONLY : CRGSWC => RGSWC
USE cable_photo_constants_mod, ONLY : CRGBWC => RGBWC

IMPLICIT NONE

TYPE (radiation_type), INTENT(INOUT) :: rad
TYPE (roughness_type), INTENT(INOUT) :: rough
TYPE (air_type), INTENT(INOUT) :: air
Expand Down Expand Up @@ -145,7 +153,9 @@ SUBROUTINE dryLeaf( dels, rad, rough, air, met, &
! END header

ALLOCATE( gswmin(mp,mf ))


gs_coeff(:,:) = 0.0 ! CABLE_ISSUE39

! Soil water limitation on stomatal conductance:
IF( iter ==1) THEN
IF ((cable_user%soil_struc=='default').AND.(cable_user%FWSOIL_SWITCH.NE.'Haverd2013')) THEN
Expand Down Expand Up @@ -319,36 +329,38 @@ SUBROUTINE dryLeaf( dels, rad, rough, air, met, &
!1.2877 + (0.0116 × Vcmax,a25) – (0.0334 × TWQ)
!Shrubs: Rdark,a25 = 1.5758 + (0.0116 × Vcmax,a25) – (0.0334 × TWQ)

IF (veg%iveg(i).EQ.2 .OR. veg%iveg(i).EQ. 4 ) THEN ! broadleaf forest

rdx(i,1) = 0.60*(1.2818e-6+0.0116*veg%vcmax(i)- &
0.0334*climate%qtemp_max_last_year(i)*1e-6)
rdx(i,2) = rdx(i,1)

ELSEIF (veg%iveg(i).EQ.1 .OR. veg%iveg(i).EQ. 3 ) THEN ! needleleaf forest
rdx(i,1) = 1.0*(1.2877e-6+0.0116*veg%vcmax(i)- &
0.0334*climate%qtemp_max_last_year(i)*1e-6)
rdx(i,2) = rdx(i,1)

ELSEIF (veg%iveg(i).EQ.6 .OR. veg%iveg(i).EQ.8 .OR. &
veg%iveg(i).EQ. 9 ) THEN ! C3 grass, tundra, crop
rdx(i,1) = 0.60*(1.6737e-6+0.0116*veg%vcmax(i)- &
0.0334*climate%qtemp_max_last_year(i)*1e-6)
rdx(i,2) = rdx(i,1)

ELSE ! shrubs and other (C4 grass and crop)
rdx(i,1) = 0.60*(1.5758e-6+0.0116*veg%vcmax(i)- &
0.0334*climate%qtemp_max_last_year(i)*1e-6)
rdx(i,2) = rdx(i,1)
! broadleaf forest
IF ( veg%iveg(i) .EQ. evergreen_broadleaf .OR. &
veg%iveg(i) .EQ. deciduous_broadleaf ) THEN

rdx(i,:) = 0.60 * ( 1.2818e-6 + 0.0116 * veg%vcmax(i) - &
0.0334 * climate%qtemp_max_last_year(i) * 1.0e-6 )

! needleleaf forest
ELSEIF ( veg%iveg(i) .EQ. evergreen_needleleaf .OR. &
veg%iveg(i) .EQ. deciduous_needleleaf ) THEN

rdx(i,:) = 1.0 * ( 1.2877e-6 + 0.0116 * veg%vcmax(i) - &
0.0334 * climate%qtemp_max_last_year(i) * 1.0e-6 )

! C3 grass, tundra , C3 crop
ELSEIF ( veg%iveg(i) .EQ. c3_grassland .OR. &
veg%iveg(i) .EQ. tundra .OR. &
veg%iveg(i) .EQ. c3_cropland ) THEN

rdx(i,:) = 0.60 * ( 1.6737e-6 + 0.0116 * veg%vcmax(i) - &
0.0334 * climate%qtemp_max_last_year(i) * 1e-6 )

! shrub & other (C4 grass and C4 crop) (wetlands, nveg) TBC
ELSE
rdx(i,:) = 0.60 * ( 1.5758e-6 + 0.0116 * veg%vcmax(i) - &
0.0334 * climate%qtemp_max_last_year(i) * 1.0e-6 )
ENDIF


! modify for leaf area and instanteous temperature response (Rd25 -> Rd)
rdx(i,1) = rdx(i,1) * xrdt(tlfx(i)) * rad%scalex(i,1)
rdx(i,2) = rdx(i,2) * xrdt(tlfx(i)) * rad%scalex(i,2)



! reduction of daytime leaf dark-respiration to account for
!photo-inhibition
!Mercado, L. M., Huntingford, C., Gash, J. H. C., Cox, P. M.,
Expand All @@ -369,15 +381,8 @@ SUBROUTINE dryLeaf( dels, rad, rough, air, met, &
rdx(i,2) = rdx(i,2) * &
(0.5 - 0.05*LOG(jtomol*1.0e6*rad%qcan(i,1,2)))

!$ xleuning(i,1) = ( fwsoil(i) / ( csx(i,1) - co2cp3 ) ) &
!$ * ( veg%a1gs(i) / ( 1.0 + dsx(i)/veg%d0gs(i)))
!$ xleuning(i,2) = ( fwsoil(i) / ( csx(i,2) - co2cp3 ) ) &
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commenting style has lead to issues in some UM builds. Its redundant code anyway

!$ * ( veg%a1gs(i) / ( 1.0 + dsx(i)/veg%d0gs(i)))

ELSE !cable_user%call_climate

!$!Vanessa:note there is no xleuning to go into photosynthesis etc anymore
!$ gs_coeff = xleuning

rdx(i,1) = (veg%cfrd(i)*vcmxt3(i,1) + veg%cfrd(i)*vcmxt4(i,1))
rdx(i,2) = (veg%cfrd(i)*vcmxt3(i,2) + veg%cfrd(i)*vcmxt4(i,2))
Expand Down Expand Up @@ -494,12 +499,12 @@ SUBROUTINE dryLeaf( dels, rad, rough, air, met, &
REAL(veg%froot(i,:),r_2),&
soil%ssat_vec(i,:), &
soil%swilt_vec(i,:), &
MAX(REAL(canopy%fevc(i)/air%rlam(i)/1000_r_2,r_2),0.0_r_2), &
MAX(REAL(canopy%fevc(i)/air%rlam(i)/density_liq,r_2),0.0_r_2), &
REAL(veg%gamma(i),r_2), &
REAL(soil%zse,r_2), REAL(dels,r_2), REAL(veg%zr(i),r_2))

fwsoil(i) = canopy%fwsoil(i)
ssnow%evapfbl(i,:) = ssnow%rex(i,:)*dels*1000_r_2 ! mm water &
ssnow%evapfbl(i,:) = ssnow%rex(i,:)*dels*density_liq ! mm water &
!(root water extraction) per time step

ELSE
Expand All @@ -513,7 +518,7 @@ SUBROUTINE dryLeaf( dels, rad, rough, air, met, &
ssnow%evapfbl(i,kk) = MIN( evapfb(i) * veg%froot(i,kk), &
MAX( 0.0, REAL( ssnow%wb(i,kk) ) - &
1.1 * soil%swilt(i) ) * &
soil%zse(kk) * 1000.0 )
soil%zse(kk) * density_liq )

ENDDO
IF (cable_user%soil_struc=='default') THEN
Expand Down
5 changes: 4 additions & 1 deletion src/science/canopy/cbl_latent_heat.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,10 @@ SUBROUTINE Latent_heat_flux( mp, CTFRZ, dels, soil_zse, soil_swilt, &
! over snow. And the value for points with new snow could be smaller.


USE cable_def_types_mod, ONLY : r_2
USE cable_def_types_mod, ONLY : r_2
USE cable_common_module, ONLY: frozen_limit
USE cable_phys_constants_mod, ONLY: density_liq

IMPLICIT NONE

INTEGER :: mp
Expand Down
5 changes: 5 additions & 0 deletions src/science/canopy/cbl_photosynthesis.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ SUBROUTINE photosynthesis( csxz, cx1z, cx2z, gswminz, &

INTEGER :: i,j

anrubpz(:,:) = 0.0
ansinkz(:,:) = 0.0
anxz(:,:) = 0.0
anrubiscoz(:,:) = 0.0

DO i=1,mp

IF (SUM(vlaiz(i,:)) .GT. CLAI_THRESH) THEN
Expand Down
Loading