mods from AM3 corresponding to #496 here and a few others #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JhanSrbinovsky
commented
Jan 7, 2025
There was a problem hiding this comment.
definitely suggest you hide whitespace differences here
JhanSrbinovsky
commented
Jan 7, 2025
There was a problem hiding this comment.
surprising this was never picked up before AM3
har917
reviewed
Jan 7, 2025
src/science/canopy/cable_canopy.F90
Outdated
| @@ -84,7 +84,7 @@ SUBROUTINE define_canopy(bal,rad,rough,air,met,dels,ssnow,soil,veg, canopy,clima | |||
| TYPE (veg_parameter_type), INTENT(INOUT) :: veg | |||
|
|
|||
| REAL :: reducedLAIdue2snow(mp) | |||
| LOGICAL :: sunlit_veg_mask(mp) | |||
| logical :: sunlit_veg_mask(mp) | |||
There was a problem hiding this comment.
Don't the coding standards indicate we should be using capitals? i.e. LOGICAL not logical
har917
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CABLE
Thank you for submitting a pull request to the CABLE Project.
Description
#496
Fixes #496
Type of change
Please delete options that are not relevant.
Checklist
Please add a reviewer when ready for review.
📚 Documentation preview 📚: https://cable--519.org.readthedocs.build/en/519/