Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact CBA JointRails Compatibility #1283

Closed
NorXAengell opened this issue Jan 17, 2020 · 7 comments
Closed

Contact CBA JointRails Compatibility #1283

NorXAengell opened this issue Jan 17, 2020 · 7 comments
Labels

Comments

@NorXAengell
Copy link

Could you add Contact weapons to use CBA JointRails classes.

Like this mod : https://steamcommunity.com/sharedfiles/filedetails/?id=1888068830&searchtext=

Thx guys :)

@dedmen
Copy link
Contributor

dedmen commented Jan 18, 2020

I'll never understand why people don't just make a pull request, but instead go to the effort to make a full sub-mod that does the same.

@commy2
Copy link
Contributor

commy2 commented Jan 18, 2020

Yeah, now I am stuck here unable to look at the code, because the workshop doesn't work for me and I never used it before.

@commy2
Copy link
Contributor

commy2 commented Jan 18, 2020

Also, isn't this the same as #1190?

@Drofseh
Copy link
Contributor

Drofseh commented Jan 18, 2020

Also, isn't this the same as #1190?

No, that one is for magwells and this one is for rails.

@commy2
Copy link
Contributor

commy2 commented Jan 18, 2020

And where's the difference? Practically I mean?

@jonpas
Copy link
Member

jonpas commented Jan 18, 2020

That you need to add different classes? 🤔

@commy2 commy2 added Task and removed Feature labels Jan 19, 2020
@commy2 commy2 added this to the 3.13.1 milestone Jan 19, 2020
@commy2
Copy link
Contributor

commy2 commented Jan 19, 2020

@NorXAengell
I checked ingame and the Promet ("contact weapon") can use all base game items.

If you have a 3rd party mod that has optics that are incompatible with the weapon, then that is because the Promet uses the MuzzleSlot_65 and CowsSlot_MSBS65 attachment classes. That 3rd party mod author has to add their optics to those classes as well as the CBA JR classes.

The addon you posted (from the Steam side) in fact breaks all addons that correctly add their attachments to the MuzzleSlot_65 etc. class and don't bother with CBA.

The issue is basically the same as this: #1258 (comment), except that these weapons are obviously not covered by the legacy component.

@commy2 commy2 closed this as completed Jan 19, 2020
@commy2 commy2 added the Invalid label Jan 19, 2020
@commy2 commy2 removed this from the 3.13.1 milestone Jan 19, 2020
@commy2 commy2 removed the Task label Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants