Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neptune Module Enhancements #191

Merged
merged 37 commits into from
Apr 2, 2024
Merged

Neptune Module Enhancements #191

merged 37 commits into from
Apr 2, 2024

Conversation

colemandevries
Copy link
Contributor

@colemandevries colemandevries commented Mar 11, 2024 •
edited
Loading

Change Objectives:
To modify the Neptune module to increase compatibility with provisioned cluster deployments in addition to the existing serverless cluster deployment options, and to ensure alignment with program standards for self-contained modules.

The changes raised in this pull request include:

  1. Converting calls to other external modules (i.e. parameter groups, neptune cluster instance) to stand-alone resources defined in the cluster module itself to align with CTOS standard conventions.
  2. Updated the cluster definition to be more suitable for provisioned deployment models (as opposed to serverless).
  3. Updated variables and outputs to support addition of resources and changes for provisioned cluster suitability.

colemandevries and others added 21 commits March 11, 2024 12:10
@colemandevries
added the create_parameter_groups variable with a default of false
19198ff
@colemandevries
added local for control over parameter group creation logic, updated …
2220cba 
…param group count conditions
@colemandevries
updated variables and added new stand-alone resource for cluster para…
f9b3edf 
…meters
@colemandevries
adding stand-alone instance parameter group resource rather than call…
14137a8 
… ext module
@colemandevries
revised outputs for new resources that replaced external modules
538c6e4
@github-actions
terraform-docs: automated action
2b1acd1
@colemandevries
resolved errors due to module dependencies
62f0f4e
@colemandevries
updated the address of the instance resource in outputs by removing i…
f7ee9af 
…terators
@colemandevries
resolved instance dbi_resource_id output typo
d7e47a0
@colemandevries
updated serverless neptune default cluster value for the cluster
dc2e733
@github-actions
terraform-docs: automated action
7db5c47
@colemandevries
fixed variable issue with cloudwatch log exports
0f1d1c6
@github-actions
terraform-docs: automated action
e3d6b62
@colemandevries
resolving issues with parameter groups specifications
5b07e13
@colemandevries
Merge branch 'neptune-module' of https://github.com/CBIIT/datacommons…
1e19083 
…-devops into neptune-module
@colemandevries
just formatting
84f3699
@colemandevries
removed backup and maintenance windows for instance since they are de…
5f7f5cf 
…fined with cluster
@colemandevries
using a key alias for neptune cluster
db95f33
@colemandevries
added lifecycle rule
0a72b7d
@colemandevries
added a parameter group dependency for neptune
6e292d9
@colemandevries
fixed invalid reference to a db parameter group
4cf7856
@kiran1942 kiran1942 merged commit dcbecac into main Apr 2, 2024
1 of 2 checks passed
@michael-fleming michael-fleming deleted the neptune-module branch May 29, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiran1942 kiran1942 kiran1942 approved these changes

@michael-fleming michael-fleming Awaiting requested review from michael-fleming

Assignees

@colemandevries colemandevries

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemandevries @kiran1942