Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Os module #206

Merged
merged 35 commits into from
Jun 26, 2024
Merged

Os module #206

merged 35 commits into from
Jun 26, 2024

Conversation

michael-fleming
Copy link
Contributor

updates to Kinesis and Opensearch modules:

Kinesis:

  • updated s3 destination to extended s3
  • moved s3 configuration block in main.tf

Opensearch:

  • updated resource identifiers in data.tf due to race condition (the policies being created referenced resources they were required to be attached to)
  • added locals for security group, subnet, and autotune options and used these in the cluster creation

Copy link
Contributor

@colemandevries colemandevries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @michael-fleming - the changes you made look great. I think this is ready for testing. Please note that I did not review the Kinesis module changes included in this pull request, just focused on OpenSearch.

@michael-fleming michael-fleming merged commit 6f4c6a9 into main Jun 26, 2024
1 check passed
@michael-fleming michael-fleming deleted the os_module branch June 26, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants