Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix window resizing #320

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Fix window resizing #320

merged 2 commits into from
Jul 8, 2024

Conversation

2767mr
Copy link
Member

@2767mr 2767mr commented Jul 5, 2024

Hopefully closes #319

@2767mr 2767mr requested a review from Vegita2 July 5, 2024 22:54
@Vegita2
Copy link
Member

Vegita2 commented Jul 6, 2024

I didn't try it yet, but do you know why this solves it? I never really understood how that zoom property works and came to the current version through trial and error

@2767mr
Copy link
Member Author

2767mr commented Jul 6, 2024

When I was debugging it, it seemed to be a Phaser bug: If you call setZoom it believes that the size of the canvas has been adjusted as well (even though it hasn't) and then no longer resizes the canvas upon calling resize since it believes it is already the correct size.
Not sure how the zoom property works either.

@2767mr 2767mr merged commit e8c0941 into master Jul 8, 2024
5 checks passed
@2767mr 2767mr deleted the fix/resizing branch July 8, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vegita2 Vegita2 Awaiting requested review from Vegita2

Assignees
No one assigned
Labels
bump:patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resizing the window now breaks the game canvas
2 participants
@2767mr @Vegita2