Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor infectionswithfeedback.py to allow shared infection feedback strength across sites #470

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

sbidari
Copy link
Collaborator

@sbidari sbidari commented Oct 3, 2024

Used jnp.broadcast instead of padding to get desired shape for infection_feedback_strength. This allows flexibility of having shared or individual infection feedback strength across different sites/sub populations which the previous version did not.

This change also makes pad_edges_to_match function from the arrayutils unnecessary but I left it for now.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.40%. Comparing base (9bc3dae) to head (e4a28ab).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pyrenew/latent/infectionswithfeedback.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
- Coverage   94.41%   94.40%   -0.02%     
==========================================
  Files          42       42              
  Lines        1003     1000       -3     
==========================================
- Hits          947      944       -3     
  Misses         56       56              
Flag Coverage Δ
unittests 94.40% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbidari sbidari marked this pull request as ready for review October 3, 2024 19:33
Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much better solution, thanks @sbidari!

@dylanhmorris dylanhmorris merged commit 32e80fd into main Oct 3, 2024
5 of 7 checks passed
@dylanhmorris dylanhmorris deleted the sb_allow_shared_inf_feedback_across_site branch October 3, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants