-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
~~Test~~ Demo using data from WW R package #55
~~Test~~ Demo using data from WW R package #55
Conversation
I'm holding making progress on this one until #60 is merged. |
…formed-covid-forecasting-testing
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
+ Coverage 90.57% 92.09% +1.51%
==========================================
Files 28 33 +5
Lines 552 620 +68
==========================================
+ Hits 500 571 +71
+ Misses 52 49 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
model/src/pyrenew/datasets/data-raw/infection_admission_interval.py
Outdated
Show resolved
Hide resolved
@dylanhmorris and @AFg6K7h4fhy2, this PR is ready for review. The only problem is a test that checks the |
Some context: @gvegayon and I just re-ran with the Obviously, that can't fix the whole problem because of how the infection -> hosp obs. delay works. |
OK, @dylanhmorris, this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few key questions, mostly looks ready @gvegayon
model/src/pyrenew/datasets/data-raw/infection_admission_interval.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>
Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>
…al.py Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>
Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>
…formed-covid-forecasting-testing
This PR does the following:
datasets
submodule that includes test data generated by the WW team (see here)- [ ] It usesHospitalizationsModel
to fit the data and compares it with the estimates obtained from the R package.padding
argument to the hospital admissions and basic renewal model. The padding assumes the firstpadding
observations arenan
.From the 🏰 Gargoyleosaurus sprint (April 12)
Part of the PR initially wanted to deal with adding a test comparing the results of the WW hospitalization model in R. Still, the plans changed as the number of codebase modifications grew substantially. Things that need to be addressed during the next sprint:
Check the initialization of the model: The first half of NUTS estimated hospitalizations doesn't cover the data properly:cc @dylanhmorris, @SamuelBrand1