-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean Model Documentation #94
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
===========================================
+ Coverage 90.57% 100.00% +9.42%
===========================================
Files 28 2 -26
Lines 552 7 -545
===========================================
- Hits 500 7 -493
+ Misses 52 0 -52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
OK, @AFg6K7h4fhy2. I fixed it:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR does several things for the MSR model documentation. Namely:
any
,tuple
instead ofAny
,Tuple
fromtyping
Optional
s fromtyping