Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ersd warnings #2632

Merged
merged 12 commits into from
Sep 27, 2024
Merged

add ersd warnings #2632

merged 12 commits into from
Sep 27, 2024

Conversation

lina-roth
Copy link
Collaborator

@lina-roth lina-roth commented Sep 26, 2024 •
edited
Loading

PULL REQUEST

Screen Shot 2024-09-27 at 11 34 00 AM

Summary

  • Add eRSD Warning fhir conversion, fhirpath, and display in Ecr Metadata

Related Issue

Fixes #2505

Acceptance Criteria

  • when available, eRSD warning data/messages are extracted from RRs and added to the FHIR bundle
  • eRSD warnings table added within the eCR Metadata section
  • Table contains:
  • Warning text
  • Version in use
  • Expected version
  • Suggested solution
  • When eRSD warning comes in on an eCR, this table is populated
  • Table follows design and meets styling requirements

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@sarahtress
Copy link
Collaborator

sarahtress commented Sep 27, 2024 •
edited
Loading

@lina-roth looks good, just one little request - the lines i put in brackets in the screenshot below are too dark compared to the lines elsewhere. can you match them to the other lines? thanks!

Screenshot 2024-09-27 at 11 19 58 AM

@sarahtress
Copy link
Collaborator

passed design review!

@lina-roth lina-roth removed the request for review from sarahtress September 27, 2024 16:30
BobanL
BobanL reviewed Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits, but otherwise looks good 😸

containers/ecr-viewer/src/app/services/ecrMetadataService.ts Outdated Show resolved Hide resolved
containers/ecr-viewer/src/app/services/ecrMetadataService.ts Outdated Show resolved Hide resolved
containers/ecr-viewer/src/app/services/ecrMetadataService.ts Outdated Show resolved Hide resolved
containers/ecr-viewer/src/app/services/ecrMetadataService.ts Outdated Show resolved Hide resolved
containers/fhir-converter/Templates/eCR/Resource/_Composition.liquid Outdated Show resolved Hide resolved
BobanL
BobanL approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@lina-roth lina-roth added this pull request to the merge queue Sep 27, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 27, 2024
@lina-roth
add ersd warnings (#2632)
de62b3d 
* add ersd warnings

* Complete styling of table

* Fix linting issues

* Update test snapshot

* Add tests

* Design Review update and remove log

* Fix build issue

* Address requested changes

* Use built in whitespace control
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2024
@lina-roth lina-roth added this pull request to the merge queue Sep 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2024
@lina-roth lina-roth added this pull request to the merge queue Sep 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2024
@lina-roth lina-roth added this pull request to the merge queue Sep 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2024
@lina-roth lina-roth added this pull request to the merge queue Sep 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2024
@lina-roth lina-roth added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 8b26578 Sep 27, 2024
32 checks passed
@lina-roth lina-roth deleted the lr/ersd-warning branch September 27, 2024 21:36
BobanL pushed a commit to BobanL/phdi that referenced this pull request Oct 11, 2024
@lina-roth
add ersd warnings (CDCgov#2632)
c4d08f0 
* add ersd warnings

* Complete styling of table

* Fix linting issues

* Update test snapshot

* Add tests

* Design Review update and remove log

* Fix build issue

* Address requested changes

* Use built in whitespace control
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobanL BobanL BobanL approved these changes

@angelathe angelathe Awaiting requested review from angelathe

@JNygaard-Skylight JNygaard-Skylight Awaiting requested review from JNygaard-Skylight

@gordonfarrell gordonfarrell Awaiting requested review from gordonfarrell

@austin-hall-skylight austin-hall-skylight Awaiting requested review from austin-hall-skylight

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add eRSD warnings to the eCR Viewer
3 participants
@lina-roth @sarahtress @BobanL