Skip to content

Commit

Permalink
Check submission table when computing submission history
Browse files Browse the repository at this point in the history
  • Loading branch information
thetaurean committed Oct 11, 2024
1 parent 80f9da6 commit 3a4225d
Show file tree
Hide file tree
Showing 3 changed files with 60 additions and 5 deletions.
14 changes: 10 additions & 4 deletions prime-router/src/main/kotlin/history/azure/ReportFileFunction.kt
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import gov.cdc.prime.router.CustomerStatus
import gov.cdc.prime.router.RESTTransportType
import gov.cdc.prime.router.azure.DataAccessTransaction
import gov.cdc.prime.router.azure.HttpUtilities
import gov.cdc.prime.router.azure.SubmissionTableService
import gov.cdc.prime.router.azure.WorkflowEngine
import gov.cdc.prime.router.azure.db.tables.pojos.Action
import gov.cdc.prime.router.history.ReportHistory
Expand Down Expand Up @@ -161,10 +162,15 @@ abstract class ReportFileFunction(
} catch (e: DataAccessException) {
logger.error("Unable to fetch history for ID $id", e)
return HttpUtilities.internalErrorResponse(request)
} catch (ex: IllegalStateException) {
logger.error(ex)
// Errors above are actionId or UUID not found errors.
return HttpUtilities.notFoundResponse(request, ex.message)
} catch (ex: IllegalStateException) { // actionId or UUID not found
val submission = SubmissionTableService.getInstance().getSubmission(id, "Received")

return if (submission == null) {
logger.error(ex)
HttpUtilities.notFoundResponse(request, ex.message)
} else {
HttpUtilities.okJSONResponse(request, submission)
}
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package gov.cdc.prime.router.history.azure
import assertk.assertThat
import assertk.assertions.isEqualTo
import assertk.assertions.isNotNull
import gov.cdc.prime.reportstream.shared.Submission
import gov.cdc.prime.router.ActionLog
import gov.cdc.prime.router.ActionLogLevel
import gov.cdc.prime.router.FileSettings
Expand All @@ -11,6 +12,7 @@ import gov.cdc.prime.router.Metadata
import gov.cdc.prime.router.MimeFormat
import gov.cdc.prime.router.Topic
import gov.cdc.prime.router.azure.MockHttpRequestMessage
import gov.cdc.prime.router.azure.SubmissionTableService
import gov.cdc.prime.router.azure.WorkflowEngine
import gov.cdc.prime.router.azure.db.enums.TaskAction
import gov.cdc.prime.router.common.BaseEngine
Expand All @@ -26,13 +28,16 @@ import gov.cdc.prime.router.tokens.oktaSystemAdminGroup
import gov.cdc.prime.router.unittest.UnitTestUtils
import io.mockk.clearAllMocks
import io.mockk.every
import io.mockk.mockk
import io.mockk.mockkObject
import io.mockk.unmockkAll
import org.junit.jupiter.api.AfterEach
import org.junit.jupiter.api.BeforeEach
import org.junit.jupiter.api.Test
import org.junit.jupiter.api.extension.ExtendWith
import org.testcontainers.junit.jupiter.Testcontainers
import java.time.OffsetDateTime
import java.time.ZoneOffset

@Testcontainers
@ExtendWith(ReportStreamTestDatabaseSetupExtension::class)
Expand Down Expand Up @@ -69,6 +74,40 @@ class SubmissionFunctionIntegrationTests {
assertThat(historyNode.get("warnings").size()).isEqualTo(0)
}

@Test
fun `it should return a history for a submission received by the submissions microservice`() {
val timestamp = OffsetDateTime.now(ZoneOffset.UTC)
val submissionId = "some-submission-id"
val submissionTableService = mockk<SubmissionTableService>()
every { submissionTableService.getSubmission(any(), any()) } returns Submission(
submissionId,
"Received",
"some-url",
"some-detail",
timestamp
)

mockkObject(SubmissionTableService.Companion)
every { SubmissionTableService.getInstance() } returns submissionTableService

val httpRequestMessage = MockHttpRequestMessage()

val func = setupSubmissionFunction()

val history = func.getReportDetailedHistory(httpRequestMessage, submissionId)
assertThat(history).isNotNull()

val historyNode = JacksonMapperUtilities.defaultMapper.readTree(history.body.toString())
assertThat(historyNode.fieldNames().asSequence().toList()).isEqualTo(
listOf("submissionId", "overallStatus", "timestamp")
)
assertThat(historyNode.get("submissionId").asText()).isEqualTo(submissionId)
assertThat(historyNode.get("overallStatus").asText()).isEqualTo("Received")
assertThat(historyNode.get("timestamp").asText()).isEqualTo(
timestamp.format(JacksonMapperUtilities.timestampFormatter)
)
}

@Test
fun `it should return a history for partially delivered submission`() {
val submittedReport = reportGraph {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
package gov.cdc.prime.reportstream.shared

import com.azure.data.tables.models.TableEntity
import com.fasterxml.jackson.annotation.JsonIgnore
import com.fasterxml.jackson.annotation.JsonProperty
import com.fasterxml.jackson.annotation.JsonPropertyOrder
import java.time.OffsetDateTime

/**
* Represents a submission entity to be stored in Azure Table Storage.
Expand All @@ -10,11 +14,16 @@ import com.azure.data.tables.models.TableEntity
* @property bodyURL The URL pointing to the body of the submission.
* @property detail Optional additional details about the submission.
*/
@JsonPropertyOrder(value = ["submissionId", "overallStatus", "timestamp"])
data class Submission(
val submissionId: String,
@JsonProperty("overallStatus")
val status: String,
@JsonIgnore
val bodyURL: String,
@JsonIgnore
val detail: String? = null,
val timestamp: OffsetDateTime? = null
) {
companion object {
/**
Expand All @@ -28,7 +37,8 @@ data class Submission(
submissionId = tableEntity.partitionKey,
status = tableEntity.rowKey,
bodyURL = tableEntity.getProperty("body_url") as String,
detail = tableEntity.getProperty("detail") as String?
detail = tableEntity.getProperty("detail") as String?,
timestamp = tableEntity.timestamp
)
}
}
Expand Down

0 comments on commit 3a4225d

Please sign in to comment.