Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating MO test to prove that the truncaiton is working and to make … #15424

Merged

Conversation

JessicaWNava
Copy link
Collaborator

@JessicaWNava JessicaWNava commented Jul 31, 2024

…their test more accurate

This PR updates the MO testing to prove out truncation works for integration tests and to make their tests more accurate.

Test Steps:

  1. Make sure the tests run
  2. View that the fields are truncated.

Changes

  • Updated MO tests
  • Added MO receiver to testIntegation organizations file.
  • Added a receiver to MO tests

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Linked Issues

#issue 15109

To Be Done

Create GitHub issues to track the work remaining, if any

  • #issue

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints?
    • new endpoint A
    • new endpoint B
  • Does this PR include changes in authentication and/or authorization of existing endpoints?
  • Does this change introduce new dependencies that need vetting?
  • Does this change require changes to our infrastructure?
  • Does logging contain sensitive data?
  • Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

  • What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated
    • Spoofing (faking authenticity)
      • Threat T, which could be achieved by A, is mitigated by M
    • Tampering (influence or sabotage the integrity of information, data, or system)
    • Repudiation (the ability to dispute the origin or originator of an action)
    • Information disclosure (data made available to entities who should not have it)
    • Denial of service (make a resource unavailable)
    • Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)
  • Have you ensured logging does not contain sensitive data?
  • Have you received any additional approvals needed for this change?

@JessicaWNava JessicaWNava requested a review from a team as a code owner July 31, 2024 19:23
Copy link

github-actions bot commented Jul 31, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

github-actions bot commented Jul 31, 2024

Test Results

1 196 tests   1 192 ✅  6m 18s ⏱️
  158 suites      4 💤
  158 files        0 ❌

Results for commit a590f28.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 31, 2024

Integration Test Results

 63 files   63 suites   29m 51s ⏱️
424 tests 415 ✅ 9 💤 0 ❌
427 runs  418 ✅ 9 💤 0 ❌

Results for commit a590f28.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Aug 12, 2024

@JessicaWNava JessicaWNava merged commit 5fd54fe into master Aug 12, 2024
22 checks passed
@JessicaWNava JessicaWNava deleted the engagement/jessica/15109-integration-test-truncation branch August 12, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants