Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove faker #581

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Remove faker #581

merged 1 commit into from
Aug 9, 2023

Conversation

alismx
Copy link
Collaborator

@alismx alismx commented Aug 9, 2023 •
edited
Loading

Related Issue or Background Info

Changes Proposed

  • Remove faker because we aren't using it.

Additional Information

  • This version of faker is unusable. The maintainer deliberately removed the functional code from this package. This is related to the colors.js CVE-2021-23567.
  • If we want to use faker, the functional code for this package was forked and can be found here.

Checklist for Author and Reviewer

Design

  • Any UI/UX changes have a designer as a reviewer, and changes have been approved
  • Any large-scale changes have been deployed to test, dev, or pentest and smoke-tested by both the engineering and design teams

Content

  • Any content changes (including new error messages) have been approved by content team

Support

  • Any changes that might generate new support requests have been flagged to the support team

Testing

  • Includes a summary of what a code reviewer should verify

emyl3
emyl3 approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the cleanup

@alismx alismx merged commit 4cfe561 into main Aug 9, 2023
6 checks passed
@alismx alismx deleted the alis/remove_faker branch August 9, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyl3 emyl3 emyl3 approved these changes

@zdeveloper zdeveloper Awaiting requested review from zdeveloper

@nathancrtr nathancrtr Awaiting requested review from nathancrtr

@johanna-skylight johanna-skylight Awaiting requested review from johanna-skylight

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove faker
2 participants
@alismx @emyl3