Implemented fixed to improve date picker experience (#6073)

CDCgov · Jul 6, 2023 · ea8e101 · ea8e101
1 parent 01a8469
commit ea8e101
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 4 deletions.
diff --git a/frontend/src/app/testResults/TestResultsList.tsx b/frontend/src/app/testResults/TestResultsList.tsx
@@ -465,6 +465,7 @@ export const DetachedTestResultsList = ({
           <div
             id="test-results-search-by-patient-input"
             className="position-relative bg-base-lightest"
+            role="search"
           >
             <div className="display-flex grid-row grid-gap flex-row flex-align-end padding-x-3 padding-y-2">
               <div className="person-search">
@@ -496,7 +497,6 @@ export const DetachedTestResultsList = ({
                   className="usa-input"
                   min="2000-01-01"
                   max={maxDate}
-                  aria-label="Start Date"
                   onChange={(e) => processStartDate(e.target.value)}
                   defaultValue={getDateOrEmptyString(filterParams.startDate)}
                 />
@@ -510,7 +510,6 @@ export const DetachedTestResultsList = ({
                   className="usa-input"
                   min="2000-01-01"
                   max={maxDate}
-                  aria-label="End Date"
                   onChange={(e) => processEndDate(e.target.value)}
                   defaultValue={getDateOrEmptyString(filterParams.endDate)}
                 />

diff --git a/frontend/src/app/testResults/__snapshots__/TestResultsList.test.tsx.snap b/frontend/src/app/testResults/__snapshots__/TestResultsList.test.tsx.snap
@@ -74,6 +74,7 @@ exports[`TestResultsList should render a list of tests 1`] = `
         <div
           class="position-relative bg-base-lightest"
           id="test-results-search-by-patient-input"
+          role="search"
         >
           <div
             class="display-flex grid-row grid-gap flex-row flex-align-end padding-x-3 padding-y-2"
@@ -131,7 +132,6 @@ exports[`TestResultsList should render a list of tests 1`] = `
                 Date range (start)
               </label>
               <input
-                aria-label="Start Date"
                 class="usa-input"
                 id="start-date"
                 max="2022-09-26"
@@ -151,7 +151,6 @@ exports[`TestResultsList should render a list of tests 1`] = `
                 Date range (end)
               </label>
               <input
-                aria-label="End Date"
                 class="usa-input"
                 id="end-date"
                 max="2022-09-26"

diff --git a/frontend/src/app/testResults/mocks/queries.mock.tsx b/frontend/src/app/testResults/mocks/queries.mock.tsx
@@ -30,6 +30,21 @@ import resultForViewing from "./resultForViewing";
 import resultForCorrection from "./resultForCorrection";
 
 export const mocks = [
+  {
+    request: {
+      query: GetFacilityResultsMultiplexWithCountDocument,
+      variables: {
+        facilityId: "",
+        pageNumber: 0,
+        pageSize: 20,
+      },
+    },
+    result: {
+      data: {
+        testResultsPage: testResults,
+      },
+    },
+  },
   {
     request: {
       query: GetFacilityResultsMultiplexWithCountDocument,