Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boban/6061 admin organization query #6107

Merged
merged 13 commits into from
Jul 13, 2023
Merged

Boban/6061 admin organization query #6107

merged 13 commits into from
Jul 13, 2023

Conversation

BobanL
Copy link
Contributor

@BobanL BobanL commented Jul 10, 2023 •
edited
Loading

BACKEND PULL REQUEST

Related Issue

Changes Proposed

  • Refactor existing organization query to fetch by ID instead of by user roles.
  • Use @RequireGlobalAdminUser to enforce admin users only.

Additional Information

  • Replaced the only organization query in e2e with a whoami query

Testing

  • Deployed on dev3 - test the organization query with an ID
query Organization {
    organization(id: "0720e80c-51a9-42b1-a537-1eac73af8b2e") {
        id
        internalId
        name
        type
        externalId
        identityVerified
        patientSelfRegistrationLink
    }
}

@BobanL BobanL temporarily deployed to Dev3 July 12, 2023 14:20 — with GitHub Actions Inactive
@BobanL BobanL marked this pull request as ready for review July 12, 2023 14:21
@BobanL BobanL temporarily deployed to Dev3 July 12, 2023 16:11 — with GitHub Actions Inactive
johanna-skylight
johanna-skylight approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@johanna-skylight johanna-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in dev3. LGTM!

emyl3
emyl3 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@BobanL BobanL merged commit 45bab44 into main Jul 13, 2023
31 checks passed
@BobanL BobanL deleted the boban/6061-admin-organization-query branch July 13, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyl3 emyl3 emyl3 approved these changes

@johanna-skylight johanna-skylight johanna-skylight approved these changes

@mehansen mehansen Awaiting requested review from mehansen

@fzhao99 fzhao99 Awaiting requested review from fzhao99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Unarchive patient] Organization query updates
4 participants
@BobanL @emyl3 @johanna-skylight @fzhao99