Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility fixes: Create ID #544

Open
4 tasks done
Tracked by #546
mariagould opened this issue Jan 9, 2024 · 3 comments · May be fixed by #816
Open
4 tasks done
Tracked by #546

Accessibility fixes: Create ID #544

mariagould opened this issue Jan 9, 2024 · 3 comments · May be fixed by #816
Assignees

Comments

@mariagould
Copy link

mariagould commented Jan 9, 2024

The following accessibility issues were identified in the Create ID form (Simple and Advanced modes)

  • Fix missing fieldsets for all radio buttons
  • Change focus so it goes to main content of page, not PDFs
  • On Advanced tab, focus is invisible after selecting profile in dropdown in step 4- Focus goes to Add/Delete icons before Creator Name field. Name field should come first. (Same with Title, Description, Subject, Contributor, Date, Alternate Identifier, all the rest…)
  • Tab order for Simple and Advanced tabs is different depending on which tab you are on. If starting with Simple, can’t tab to Advanced immediate after Simple. If on Advanced, Simple immediately precedes Advanced in tab order.
@sfisher
Copy link
Contributor

sfisher commented Dec 23, 2024

Note (mostly to myself). Trying to reorder the tabs as indicated in these tickets causes all kinds of problems with the current CSS since all the display is order dependent and requires the content shows directly after the tab. Moving the content so the tab order is correct makes the content disappear completely.

Then it also broke some Javascript which took me a while to find out why (missing character in html which took me hours to see).

I have the simple create tab with the correct tab order for the tabbed interface, but now the display is completely different and bad (tabs display as huge buttons with wonky colors).

It can be fixed but will take a while for me to fix css and other stuff (and I haven't yet fixed the tab order of the "PDF" sidebar) so I'm giving up for now until after the break since it is going to take more time than I thought.

In case I need to remember the files I was working with in Jan, these are the ones and the CSS is in the SCSS ui-library.

Screenshot 2024-12-23 at 1 09 03 PM

@adambuttrick
Copy link

Thanks for all your hard work on this @sfisher and apologies that it proved more challenging than proposed! We can pick up in the new year relative to tackling all the underlying complexities.

@sfisher
Copy link
Contributor

sfisher commented Dec 23, 2024

no problem. I'm sure I'll get it working, just changing one thing made other things break.

Have good holidays!

@sfisher sfisher linked a pull request Jan 3, 2025 that will close this issue
@sfisher sfisher linked a pull request Jan 3, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants