Asn1CommandManagerTest and SecurityServicesPropertiesValidator test u…

…pdates for better validation
CDOT-CV · Nov 1, 2024 · 04cee75 · 04cee75
1 parent f0ebedc
commit 04cee75
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/...e-svcs/src/main/java/us/dot/its/jpo/ode/security/SecurityServicesPropertiesValidator.java b/...e-svcs/src/main/java/us/dot/its/jpo/ode/security/SecurityServicesPropertiesValidator.java
@@ -4,6 +4,7 @@
 
 import java.net.URI;
 import java.net.URISyntaxException;
+import java.util.Objects;
 
 public class SecurityServicesPropertiesValidator implements Validator {
 
@@ -29,7 +30,7 @@ public void validate(Object target, org.springframework.validation.Errors errors
                 if (!uri.getScheme().equals("http") && !uri.getScheme().equals("https")) {
                     errors.rejectValue(fieldName, errorCode, "Signature endpoint must be an http URL");
                 }
-                if (uri.getHost() == null || uri.getHost().isEmpty()) {
+                if (uri.getHost() == null || Objects.equals(uri.getHost(), "null") || uri.getHost().isEmpty()) {
                     errors.rejectValue(fieldName, errorCode, "Signature endpoint must have a host");
                 }
                 if (uri.getPort() < 0) {

diff --git a/jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/services/asn1/Asn1CommandManagerTest.java b/jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/services/asn1/Asn1CommandManagerTest.java
@@ -29,6 +29,7 @@
 import us.dot.its.jpo.ode.kafka.SDXDepositorTopics;
 import us.dot.its.jpo.ode.model.OdeTravelerInputData;
 import us.dot.its.jpo.ode.rsu.RsuProperties;
+import us.dot.its.jpo.ode.security.SecurityServicesProperties;
 import us.dot.its.jpo.ode.services.asn1.Asn1CommandManager.Asn1CommandManagerException;
 import us.dot.its.jpo.ode.snmp.SnmpSession;
 import us.dot.its.jpo.ode.wrapper.MessageProducer;
@@ -47,6 +48,9 @@ public class Asn1CommandManagerTest {
    @Injectable
    RsuProperties injectableRsuProperties;
 
+   @Injectable
+   SecurityServicesProperties injectableSecurityServicesProperties;
+
    @Capturing
    MessageProducer<String, String> capturingMessageProducer;
    @Capturing

diff --git a/jpo-ode-svcs/src/test/resources/application.yaml b/jpo-ode-svcs/src/test/resources/application.yaml
@@ -19,7 +19,7 @@ ode:
     brokers: "localhost:9092"
     producer:
       type: "async"
-      acks: "some"
+      acks: "0"
       retries: 1
       batch-size: 1638
       linger-ms: 2