Refactored get() method in SnmpSession class to make request even if …

…authEngineID cannot be discovered
CDOT-CV · May 9, 2024 · 3822a69 · 3822a69
1 parent be02856
commit 3822a69
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/snmp/SnmpSession.java b/jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/snmp/SnmpSession.java
@@ -139,21 +139,23 @@ public ResponseEvent set(PDU pdu, Snmp snmpob, UserTarget targetob, Boolean keep
       // Try to send the SNMP request (synchronously)
       ResponseEvent responseEvent = null;
       try {
+         // discover auth engine ID
          byte[] authEngineID = snmpob.discoverAuthoritativeEngineID(targetob.getAddress(), 1000);
          if (authEngineID != null && authEngineID.length > 0) {
             targetob.setAuthoritativeEngineID(authEngineID);
          }
-         if (authEngineID != null) {
-            responseEvent = snmpob.set(pdu, targetob);
-            if (!keepOpen) {
-               snmpob.close();
-            }
-         } else {
+         if (authEngineID == null) {
             problems.add("Failed to discover authoritative engine ID");
          }
+
+         // make request
+         responseEvent = snmpob.set(pdu, targetob);
+         if (!keepOpen) {
+            snmpob.close();
+         }
       } catch (IOException e) {
          if (!problems.isEmpty()) {
-            logger.error("Problems sending TIM to RSU {}: {}", targetob.getAddress(), problems.stream().collect(Collectors.joining(", ")));
+            logger.error("Problems sending TIM to RSU {}: {}", targetob.getAddress(), problems.stream().collect(Collectors.joining(" | ")));
          }
          throw new IOException("Failed to send SNMP request: " + e);
       }