Replaced an if-statement with a switch statement in `SnmpSession.crea…

…tePDU()` method.
CDOT-CV · Sep 11, 2023 · 947e0b5 · 947e0b5
1 parent c0d985d
commit 947e0b5
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/snmp/SnmpSession.java b/jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/snmp/SnmpSession.java
@@ -253,13 +253,12 @@ public void endSession() throws IOException {
     * @throws ParseException
     */
    public static ScopedPDU createPDU(SNMP snmp, String payload, int index, RequestVerb verb, SnmpProtocol snmpProtocol) throws ParseException {
-      if (snmpProtocol == SnmpProtocol.FOURDOT1) {
+      switch (snmpProtocol) {
+      case FOURDOT1:
          return createPDUWithFourDot1Protocol(snmp, payload, index, verb);
-      }
-      else if (snmpProtocol == SnmpProtocol.NTCIP1218) {
+      case NTCIP1218:
          return createPDUWithNTCIP1218Protocol(snmp, payload, index, verb);
-      }
-      else {
+      default:
          logger.error("Unknown SNMP protocol: {}", snmpProtocol);
          return null;
       }