Pull out default snmp set to new method

CDOT-CV · Mar 26, 2024 · fd31aea · fd31aea
1 parent 1449bf0
commit fd31aea
Showing 1 changed file with 23 additions and 32 deletions.
diff --git a/jpo-ode-plugins/src/main/java/us/dot/its/jpo/ode/plugin/RoadSideUnit.java b/jpo-ode-plugins/src/main/java/us/dot/its/jpo/ode/plugin/RoadSideUnit.java
@@ -33,22 +33,8 @@ public static class RSU extends OdeObject {
         public RSU() {
             super();
 
-            String defaultSnmpProtocol = System.getenv("DEFAULT_SNMP_PROTOCOL");
-            if (defaultSnmpProtocol != null) {
-                switch (defaultSnmpProtocol) {
-                case "FOURDOT1":
-                    this.snmpProtocol = SnmpProtocol.FOURDOT1;
-                    break;
-                case "NTCIP1218":
-                    this.snmpProtocol = SnmpProtocol.NTCIP1218;
-                    break;
-                default:
-                    this.snmpProtocol = SnmpProtocol.FOURDOT1;
-                    break;
-                }
-            } else {
-                this.snmpProtocol = SnmpProtocol.FOURDOT1;
-            }
+        setDefaultSnmpProtocol();
+
         }
 
         public RSU(String rsuTarget, String rsuUsername, String rsuPassword, int rsuRetries, int rsuTimeout) {
@@ -59,22 +45,8 @@ public RSU(String rsuTarget, String rsuUsername, String rsuPassword, int rsuRetr
             this.rsuRetries = rsuRetries;
             this.rsuTimeout = rsuTimeout;
 
-            String defaultSnmpProtocol = System.getenv("DEFAULT_SNMP_PROTOCOL");
-            if (defaultSnmpProtocol != null) {
-                switch (defaultSnmpProtocol) {
-                case "FOURDOT1":
-                    this.snmpProtocol = SnmpProtocol.FOURDOT1;
-                    break;
-                case "NTCIP1218":
-                    this.snmpProtocol = SnmpProtocol.NTCIP1218;
-                    break;
-                default:
-                    this.snmpProtocol = SnmpProtocol.FOURDOT1;
-                    break;
-                }
-            } else {
-                this.snmpProtocol = SnmpProtocol.FOURDOT1;
-            }
+            setDefaultSnmpProtocol();
+
         }
 
         public RSU(String rsuTarget, String rsuUsername, String rsuPassword, int rsuRetries, int rsuTimeout, SnmpProtocol snmpProtocol) {
@@ -138,6 +110,25 @@ public void setSnmpProtocol(SnmpProtocol snmpProtocol) {
             this.snmpProtocol = snmpProtocol;
         }
 
+        public void setDefaultSnmpProtocol() {
+            String defaultSnmpProtocol = System.getenv("DEFAULT_SNMP_PROTOCOL");
+            if (defaultSnmpProtocol != null) {
+                switch (defaultSnmpProtocol) {
+                case "FOURDOT1":
+                    this.snmpProtocol = SnmpProtocol.FOURDOT1;
+                    break;
+                case "NTCIP1218":
+                    this.snmpProtocol = SnmpProtocol.NTCIP1218;
+                    break;
+                default:
+                    this.snmpProtocol = SnmpProtocol.FOURDOT1;
+                    break;
+                }
+            } else {
+                this.snmpProtocol = SnmpProtocol.FOURDOT1;
+            }
+        }
+
         @Override
         public int hashCode() {
             final int prime = 31;