Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sping Dependencies from Maven Jars #102

Merged
merged 5 commits into from
Sep 23, 2024
Merged

Conversation

Michael7371
Copy link

@Michael7371 Michael7371 commented Sep 20, 2024

PR Details

Description

  • Creates a profile in the jpo-ode-svcs pom.xml that publishes a jar without the springboot dependencies for publishing java packages to GitHub maven repository.
  • Build without unit tests as they will fail without supporting services in GitHub actions (kafka & kafka topics)

Draft PR for testing

Related Issue

N/A

Motivation and Context

usdot-jpo-ode#555 (comment)

How Has This Been Tested?

  • By running a test trigger on the CDOT-CV fork and seeing the published package is now 212 kb.
  • I also tested the standard dockerized build and that still produces the springboot based image and performs identically to before.

Types of changes

  • [ x ] Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x ] I have read the CONTRIBUTING document.
    ODE Contributing Guide
  • I have added tests to cover my changes.
  • [ x ] All new and existing tests passed.

Copy link
Member

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neat!

@drewjj drewjj merged commit 0f66b7d into dev Sep 23, 2024
4 checks passed
@drewjj drewjj deleted the fix/reduce-publish-jar-size branch September 23, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants