Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1218 updates for TIM deposit #47

Merged
merged 4 commits into from
Dec 26, 2023
Merged

1218 updates for TIM deposit #47

merged 4 commits into from
Dec 26, 2023

Conversation

mwodahl
Copy link

@mwodahl mwodahl commented Nov 13, 2023

Includes updates to SNMP classes relating to the NTCIP1218 spec to allow TIMs to be deposited directly onto 1218-compatible RSUs

Also includes updates to reflect updated 1218 PDU values in SNMPTest and SNMPSessionTest

Copy link
Member

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and the tests pass!

I just have a few clarifying questions.

Copy link
Member

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@payneBrandon payneBrandon merged commit 87ca65d into dev Dec 26, 2023
4 checks passed
@payneBrandon payneBrandon deleted the update/snmp-1218 branch December 26, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants