Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip 1609.2 header from unsigned messages #63

Merged

Conversation

dmccoystephenson
Copy link
Member

PR Details

Description

Problem

In the event that an unsigned message contains a 1609.2 header during processing, it should be stripped.

Solution

If signing is turned off and an encoded TIM contains hex prior to '001F' (the marker for the beginning of TIM messages), the preceding hex (the header) will be stripped.

Related Issue

No related issue.

Motivation and Context

If the ODE has signing disabled, it wouldn't make sense to forward a TIM with a 1609.2 header. This may even result in problems with RSU/OBU processing.

How Has This Been Tested?

  • The unit tests have been verified to pass with these changes.
  • Artificially added 1609.2 headers have been verified to be stripped with these changes.
  • These changes have been deployed to CDOT dev and do not appear to have caused any problems with processing.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    ODE Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

@mwodahl mwodahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Unit tests are passing and changes look good

Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this should do the trick if we encounter any!

Copy link

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, makes sense!

@payneBrandon payneBrandon merged commit 58d7c92 into dev Mar 29, 2024
4 checks passed
@payneBrandon payneBrandon deleted the 1609dot2/strip-1609dot2-header-from-unsigned-messages branch March 29, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants