-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip 1609.2 header from unsigned messages #63
Strip 1609.2 header from unsigned messages #63
Conversation
…t2/strip-1609dot2-header-from-unsigned-messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Unit tests are passing and changes look good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this should do the trick if we encounter any!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, makes sense!
PR Details
Description
Problem
In the event that an unsigned message contains a 1609.2 header during processing, it should be stripped.
Solution
If signing is turned off and an encoded TIM contains hex prior to '001F' (the marker for the beginning of TIM messages), the preceding hex (the header) will be stripped.
Related Issue
No related issue.
Motivation and Context
If the ODE has signing disabled, it wouldn't make sense to forward a TIM with a 1609.2 header. This may even result in problems with RSU/OBU processing.
How Has This Been Tested?
Types of changes
Checklist:
ODE Contributing Guide